-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ELK to standalone package #5049
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #5049 +/- ##
==========================================
- Coverage 46.57% 44.37% -2.21%
==========================================
Files 55 25 -30
Lines 6819 5217 -1602
Branches 36 25 -11
==========================================
- Hits 3176 2315 -861
+ Misses 3642 2901 -741
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this approach!
The only thing I'd like to see if some E2E tests to make sure that flowchart-elk
still renders correctly on the base Mermaid and when import flowchartELK from './mermaid-flowchart-elk.esm.mjs';
is run
Allow registered diagrams to be overridden.
Co-authored-by: Alois Klink <alois@aloisklink.com>
…into sidv/splitELK * 'sidv/splitELK' of https://github.com/mermaid-js/mermaid: 5043 Allow registered diagrams to be overridden.
* next: (39 commits) reset the testTimeout to 5 seconds and change it directly in the test update testTimeout from 5 seconds to 10 seconds Update all patch dependencies fix broken link add latest blog post Update all minor dependencies fix linting fix: set proper shiki theme for light and dark modes fix: change shiki theme to github-light add latest blog post GitGraph: made reroute fn more readable GitGraph: simplified branch check in arrow rerouting fn GitGraph: added commit IDs to e2e test to remove false positives GitGraph: Moved branch curve check to within reroute check fn GitGraph: corrected minor typo in comment. GitGraph: added 2x e2e tests for branches not used immediately GitGraph: added branch checking to rerouting GitGraph: Added e2e tests for deferred branch use. GitGraph: e2e tests, added commit IDs to test graphs GitGraph: fixed an e2e branch for vertical branch ...
📑 Summary
Splits Flowchart-ELK into a separate package, to make licensing simpler.
Resolves #5043
This allows sites to fallback to dagre layout for
flowchart-elk
if the elk package is not installed, instead of completely breaking rendering.We need to pick either #5050 or #5051 for the approach to override.
📏 Design Decisions
Moved files to a new package, removed elkjs dependency from the mermaid core.
Edited tsconfig to allow import of files from mermaid, to avoid duplicating code.
📋 Tasks
Make sure you