-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update flowchart.md #5517
Update flowchart.md #5517
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5517 +/- ##
=========================================
- Coverage 5.74% 5.73% -0.01%
=========================================
Files 276 278 +2
Lines 41886 41978 +92
Branches 514 490 -24
=========================================
+ Hits 2407 2409 +2
- Misses 39479 39569 +90
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fix callback by setting the window callback to the respective callback function in the jsfiddle and code sample
Switching from develop to master so docs can be out immediately. |
@GRASBOCK, Thank you for the contribution! |
fix callback by setting the window callback to the respective callback function in the jsfiddle and code sample
📑 Summary
The documentation jsfiddle on flowchart interaction doesn't work, because the callback function is not added.
I fixed the code samples and the jsfiddle and replaced the old jsfiddle with a link to the new one.
Resolves #5510
📏 Design Decisions
Saved a new jsfiddle that contains the change and made the changes in the markdown of the docs.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch