ESLint V9 - Typed #5608
ESLint V9 - Typed #5608
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## sidv/eslintv9 #5608 +/- ##
================================================
- Coverage 5.86% 5.86% -0.01%
================================================
Files 274 274
Lines 41083 41085 +2
Branches 488 488
================================================
- Hits 2409 2408 -1
- Misses 38674 38677 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
* sidv/eslintv9: chore: Remove unused variables chore: Remove cross-env from eslint
There was a problem hiding this comment.
I've got some comments on things to potentially change in the PR.
I think I've noticed a potential bug in the extractWrap function you made, if text = '' (empty string), but 🤷, I don't know if an empty string will ever be used on that function.
Feel free to fix or ignore them and merge!
| // eslint-disable-next-line @typescript-eslint/restrict-plus-operands | ||
| return 'translate(' + labelArcGenerator.centroid(datum) + ')'; |
There was a problem hiding this comment.
Should we switch this to a template string instead?
| // eslint-disable-next-line @typescript-eslint/restrict-plus-operands | |
| return 'translate(' + labelArcGenerator.centroid(datum) + ')'; | |
| return `translate(${labelArcGenerator.centroid(datum)})`; |
There was a problem hiding this comment.
The problem is that the .centroid function returns [number, number]. So we should look into this properly, maybe when it creates an issue. Even if we use template string, it'll throw another error.
| // eslint-disable-next-line @typescript-eslint/restrict-plus-operands | ||
| textElem.attr('x', Math.round(startx + Math.abs(startx - stopx) / 2 - dim.width / 2)); |
There was a problem hiding this comment.
This seems like it might be a bug to me.
Are one of these values potentially not a number?
There was a problem hiding this comment.
That's because msgModel has a default of null, so these values have an inferred type of never.
Adding types should fix it.
* sidv/eslintv9: chore: Log granular rebuild times Separate eslint packages from updates
Co-authored-by: Alois Klink <alois@aloisklink.com>
Co-authored-by: Alois Klink <alois@aloisklink.com>
📑 Summary
Add typed rules check to ESLint v9.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch