Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning doctype so that mermaid renders in the same way with or without it #5727

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

knsv
Copy link
Collaborator

@knsv knsv commented Aug 20, 2024

📑 Summary

Aligning doctype so that mermaid renders in the same way with or without it

Resolves #5726

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 1168db6
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66c48c3eaef0780008fa5799
😎 Deploy Preview https://deploy-preview-5727--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 5.22%. Comparing base (04c29e2) to head (1168db6).
Report is 16 commits behind head on develop.

Files Patch % Lines
packages/mermaid/src/styles.ts 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5727   +/-   ##
=======================================
  Coverage     5.22%   5.22%           
=======================================
  Files          323     322    -1     
  Lines        46212   46204    -8     
  Branches       537     561   +24     
=======================================
  Hits          2415    2415           
+ Misses       43797   43789    -8     
Flag Coverage Δ
unit 5.22% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid/src/styles.ts 12.35% <0.00%> (-0.44%) ⬇️

... and 1 file with indirect coverage changes

Copy link

argos-ci bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 49 changed Aug 20, 2024, 12:43 PM

@knsv knsv merged commit 25efa4e into develop Aug 20, 2024
28 of 29 checks passed
@knsv knsv deleted the 5726_doctype branch August 20, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docttype tag affects margin in labels
2 participants