-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update entity relationship diagram to use new renderer #5965
Update entity relationship diagram to use new renderer #5965
Conversation
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5965 +/- ##
==========================================
- Coverage 3.88% 3.84% -0.05%
==========================================
Files 398 402 +4
Lines 42044 42603 +559
Branches 638 641 +3
==========================================
+ Hits 1635 1636 +1
- Misses 40409 40967 +558
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small comments to start :)
E2E tests failing because of screenshot capacity
|
…to update-er-diagram
@yari-dewalt See review comments from Applitools |
@ashishjain0512 |
@ashishjain0512 Styling of the rows now alternates between light and dark dependent on the theme. Previously it was dependent on specific theme variables attributeBackgroundColorOdd and attributeBackgroundColorEven however it looks like some were missing. I opted to use the secondaryColor and tertiaryColor variables from the themes so it's consistent or should we still use the previous variables and now expand it to make sure it works for every theme that didn't have it? We would have to come up with more colors
|
📑 Summary
Updates the er diagram to the new unified way of rendering. Includes a new "erBox" shape to be used in diagrams as well as some other updates to bring it to the same level as the other diagrams including: support for styling nodes, the handDrawn look, the introduction of the classDef statement and class styling, support for styling the default class, support for unicode text and markdown formatting, and direction statements. Adds tests for all the new features and new rendered version.
📏 Design Decisions
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.