Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Class diagram namespaces black lines, not responding to theme variables #6026

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

yari-dewalt
Copy link
Collaborator

📑 Summary

Gets rid of the default black line and transparent background styling of namespaces in class diagrams. This way the cluster is visually more consistent with other diagrams' clusters and is responsive to themes and custom theme variables.

Resolves #5669

📏 Design Decisions

Added common cluster styles from other diagrams and removed the hard coded cssStyles being applied to the namespace nodes.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: 47297f7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Nov 6, 2024
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 47297f7
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/67bf5442e63f0f000853573a
😎 Deploy Preview https://deploy-preview-6026--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Nov 6, 2024

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6026
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6026
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6026
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6026

commit: 47297f7

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 3.88%. Comparing base (446f6a7) to head (47297f7).

Files with missing lines Patch % Lines
packages/mermaid/src/diagrams/class/styles.js 0.00% 20 Missing ⚠️
packages/mermaid/src/diagrams/class/classDb.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #6026      +/-   ##
==========================================
- Coverage     3.88%   3.88%   -0.01%     
==========================================
  Files          399     399              
  Lines        42055   42075      +20     
  Branches       638     638              
==========================================
  Hits          1635    1635              
- Misses       40420   40440      +20     
Flag Coverage Δ
unit 3.88% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/diagrams/class/classDb.ts 0.00% <0.00%> (ø)
packages/mermaid/src/diagrams/class/styles.js 0.00% <0.00%> (ø)

Copy link

argos-ci bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 7 changed Feb 26, 2025, 5:59 PM

@jgreywolf
Copy link
Contributor

@yari-dewalt Can you make sure to follow up on the failures listed?

@jgreywolf
Copy link
Contributor

@yari-dewalt What is the status of this? Getting ready to make a slate of changes and figure it will be better to do after this

@ashishjain0512
Copy link
Collaborator

@yari-dewalt Please take the latest, and also, see the comments from @jgreywolf

@yari-dewalt
Copy link
Collaborator Author

@jgreywolf @ashishjain0512
Took latest and no failures, should be good to take a look at

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Black lines for namespaces in Class diagrams difficult to see in dark theme
3 participants