-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for markdown-style links #6158
base: develop
Are you sure you want to change the base?
Add support for markdown-style links #6158
Conversation
🦋 Changeset detectedLatest commit: ba259a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6158 +/- ##
==========================================
- Coverage 4.48% 3.88% -0.60%
==========================================
Files 383 399 +16
Lines 54038 42121 -11917
Branches 596 638 +42
==========================================
- Hits 2425 1638 -787
+ Misses 51613 40483 -11130
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Works great in the preview!!! @ryanwjackson, the link in
appears to be slightly below the "Look at" at the preview link above for me. |
@bernhardkaindl do you have an image of it? I see it as vertically aligned. The underline of the linked text is underneath, but the top and bottom of the text lines up for me. Let me know if I'm missing something. |
Hi @ryanwjackson thanks a bunch for implementing! I've tested in the preview (thanks @bernhardkaindl for pointing this out). And links on arrow messages are working, the alignment also seems as expected (using latest Edge).
The note link also basically works when it's a "simple" URL:
However, I've noticed two things:
Thanks and regards! EDIT: |
Hi @DanielSmithGK - Encoding the
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
I made some updates to address those issues. Let me know if that resolves them. |
📑 Summary
Add support for markdown-style links on line messages and notes
Resolves #1279
📏 Design Decisions
This currently only affects line messages and notes on sequence diagrams
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.