Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/818 add remove delay to until after and Fix/5867 #6376

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

mutricyl
Copy link

📑 Summary

Possibility to define a task start an end date relative to others is extended in this work:

  • after and until keywords can now be used for start date and end date
  • when after/until is used it is now possible to add a delay (in form of a duration). For example: 5 days after the end of task1 5d after task1

Working on that subject forced me to solve the duration issue when until is used with excluded dates #5867

Resolves #818
Resolves #5867

📏 Design Decisions

A dedicated function have been created to manage after/until keywords which is called by getStartDate and getEndDate.

fixTaskDates and checkTaskDates usage is restricted to date definition where duration is used to help resolve the duration issue when exclude is used.

task.renderEndTime is always defined to help resolve issue #5867

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Mar 13, 2025

🦋 Changeset detected

Latest commit: 7506dff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the Type: Enhancement New feature or request label Mar 13, 2025
Copy link

netlify bot commented Mar 13, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 7506dff
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/67d2bf67e867a300089255fb
😎 Deploy Preview https://deploy-preview-6376--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 88.15789% with 9 lines in your changes missing coverage. Please review.

Project coverage is 3.92%. Comparing base (d602240) to head (7506dff).

Files with missing lines Patch % Lines
packages/mermaid/src/diagrams/gantt/ganttDb.js 88.15% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #6376      +/-   ##
==========================================
+ Coverage     3.86%   3.92%   +0.06%     
==========================================
  Files          402     401       -1     
  Lines        42682   42703      +21     
  Branches       644     653       +9     
==========================================
+ Hits          1648    1676      +28     
+ Misses       41034   41027       -7     
Flag Coverage Δ
unit 3.92% <88.15%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/diagrams/gantt/ganttDb.js 76.95% <88.15%> (+0.46%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

pkg-pr-new bot commented Mar 13, 2025

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6376
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6376
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6376
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6376

commit: 7506dff

Copy link

argos-ci bot commented Mar 13, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Mar 13, 2025, 11:30 AM

@mutricyl mutricyl force-pushed the feature/818_add-remove-delay-to-until-after branch from 2fc4b4a to 7506dff Compare March 13, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
1 participant