-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/818 add remove delay to until after and Fix/5867 #6376
base: develop
Are you sure you want to change the base?
Feature/818 add remove delay to until after and Fix/5867 #6376
Conversation
🦋 Changeset detectedLatest commit: 7506dff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6376 +/- ##
==========================================
+ Coverage 3.86% 3.92% +0.06%
==========================================
Files 402 401 -1
Lines 42682 42703 +21
Branches 644 653 +9
==========================================
+ Hits 1648 1676 +28
+ Misses 41034 41027 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
commit: |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
2fc4b4a
to
7506dff
Compare
📑 Summary
Possibility to define a task start an end date relative to others is extended in this work:
5d after task1
Working on that subject forced me to solve the duration issue when until is used with excluded dates #5867
Resolves #818
Resolves #5867
📏 Design Decisions
A dedicated function have been created to manage after/until keywords which is called by getStartDate and getEndDate.
fixTaskDates and checkTaskDates usage is restricted to date definition where duration is used to help resolve the duration issue when exclude is used.
task.renderEndTime
is always defined to help resolve issue #5867📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.