-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add radar diagram #6381
feat: Add radar diagram #6381
Conversation
🦋 Changeset detectedLatest commit: bb5a7a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6381 +/- ##
========================================
Coverage 3.86% 3.86%
========================================
Files 402 412 +10
Lines 42682 43159 +477
Branches 644 664 +20
========================================
+ Hits 1648 1670 +22
- Misses 41034 41489 +455
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Textbook PR. Solid effort that ticks all boxes! 💯
I am about to write a guide on how to add new diagrams. Will use your PR as input to that process.
The only thing I have to have different is more rendering tests.
Again, solid job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate you adding the docs!
| axisLabelFactor | Factor to adjust the axis label position | `1.05` | | ||
| curveTension | Tension for the rounded curves | `0.17` | | ||
|
||
## Theme Variables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great with theme support from the start!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Langium from the start 💯
@thomascizeron I think this will be a great addition to Mermaid Diagram. I am happy to see it support the existing themes. Great PR. |
@thomascizeron, Thank you for the contribution! |
Thanks! Yeah I'm not really satisfied with testing but didn't really know how to do rendering tests, some tests appeared redundant between parser and mermaid. |
📑 Summary
Adds radar diagram
Resolves #2280
📏 Design Decisions
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.