Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Wrap: Kafel #1917

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

New Wrap: Kafel #1917

wants to merge 1 commit into from
+139 −4

Conversation

manipuladordedados
Copy link

No description provided.

dcbaker
dcbaker requested changes Feb 12, 2025
View reviewed changes
Copy link
Member

@dcbaker dcbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't fully reviewed this, but I have some comments for you.

eli-schwartz
eli-schwartz requested changes Feb 28, 2025
View reviewed changes
Copy link
Member

@eli-schwartz eli-schwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest squashing these changes into one logical change per commit.

Also, please leave a comment in the meson.build file explaining why the sed is necessary. Considering how hard it was to debug, ensuring future readers of the wrap file understand what is going on seems like a good idea.

@manipuladordedados manipuladordedados force-pushed the kfe branch 2 times, most recently from 9dc7e6a to dbcd449 Compare February 28, 2025 06:18
@manipuladordedados
Copy link
Author

I would suggest squashing these changes into one logical change per commit.

Also, please leave a comment in the meson.build file explaining why the sed is necessary. Considering how hard it was to debug, ensuring future readers of the wrap file understand what is going on seems like a good idea.

Done.

@manipuladordedados manipuladordedados marked this pull request as ready for review February 28, 2025 06:19
@manipuladordedados
Copy link
Author

Could you help me with this CI error? @dcbaker @eli-schwartz

mochaaP
mochaaP reviewed Mar 4, 2025
View reviewed changes
@manipuladordedados
Copy link
Author

The new error in the CI is:
subprojects/kafel-20231004/meson.build:7:7: ERROR: Program 'flex' not found or not executable.
I guess these containers don't have it installed?

@mochaaP
Copy link
Contributor

mochaaP commented Mar 5, 2025 •
edited
Loading

you need to declare it in ci_config.json.
example:
image

@manipuladordedados
New Wrap: Kafel
f32321e 
Update releases.json

Fix issues

Add comments

Fix soversion

Fix CI Error

Fix for CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mochaaP mochaaP mochaaP approved these changes

@dcbaker dcbaker Awaiting requested review from dcbaker

@eli-schwartz eli-schwartz Awaiting requested review from eli-schwartz

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manipuladordedados @mochaaP @dcbaker @eli-schwartz