Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made idle timeout configurable for local HTTP clients #3084

Merged

Conversation

Razz4780
Copy link
Contributor

@Razz4780 Razz4780 commented Feb 12, 2025

Issue #3072

The situation improved when we started reusing local connections, which eliminated long-standing idle connections. My suspicion is that the user application does not handle multiple open HTTP connections very well. With this config, they'll be able to have the connections killed right after the request

Copy link
Member

@DmitryDodzin DmitryDodzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM a couple of nitpicks

@Razz4780 Razz4780 enabled auto-merge February 12, 2025 13:52
@Razz4780 Razz4780 added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2025
@Razz4780 Razz4780 added this pull request to the merge queue Feb 13, 2025
Merged via the queue into metalbear-co:main with commit 642119b Feb 13, 2025
17 checks passed
@Razz4780 Razz4780 deleted the michals/mbe-711-high-latency-in-local-http branch February 13, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants