Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command to resume a specific code review #231

Closed
cateyes99 opened this issue Dec 16, 2019 · 4 comments
Closed

Add a command to resume a specific code review #231

cateyes99 opened this issue Dec 16, 2019 · 4 comments
Assignees
Labels
improvement An improvement to existing functionality
Milestone

Comments

@cateyes99
Copy link

Git Graph has a feature called Code Review. If there are multiple Code Reviews, it has a command called End All Code Reviews in Workspace to clear them. But interestingly there is no command something like List All Code Reviews in Workspace to list them, so it's actually hard to find them out. In this situation, such a List All Code Reviews in Workspace command will be very helpful.

@cateyes99 cateyes99 added the improvement An improvement to existing functionality label Dec 16, 2019
@mhutchie
Copy link
Owner

Thanks for making this suggestion, this would be great to have in Git Graph!

I think it would be nice to accompany this with a way to open the Code Review directly from the list (or something similar).

@cateyes99
Copy link
Author

It would be event better 👍

@mhutchie mhutchie added this to the v1.22.0 milestone Jan 20, 2020
mhutchie added a commit that referenced this issue Jan 27, 2020
…ce..." opens the Git Graph View to a Code Review that is already in progress.
@mhutchie mhutchie changed the title Add a command to List All Code Reviews Add a command to resume a specific code review Jan 28, 2020
@mhutchie
Copy link
Owner

I've added a new command "Git Graph: Resume a specific Code Review in Workspace...". When run, the user is shown a list of all code reviews so they can choose one to resume (or press escape if they don't want to proceed). I also implemented another command "Git Graph: End a specific Code Review in Workspace..." that behaves equivalently for ending a specific code review.

Visual Studio Code does not provide a suitable UI element for just showing a list of items without them being selectable, so I didn't implement a separate "List All Code Reviews" command. Since there is now resume and end commands, I think most users wouldn't have a need to just view a list of code reviews, without wanting to resume or end one. If the user does just want to check if any code reviews are in progress, they could always just run the resume command to see the list, then press escape to exit the list (and not proceed with resuming). If after the release I get feedback that indicates a list command would also be used, I'd be happy to add it in the following release.

This will be available in v1.22.0.

If you'd like to use it before the next release, you can download v1.22.0-beta.1, and install it following the instructions provided here.

@cateyes99
Copy link
Author

cateyes99 commented Jan 31, 2020

I've added a new command "Git Graph: Resume a specific Code Review in Workspace...". When run, the user is shown a list of all code reviews so they can choose one to resume (or press escape if they don't want to proceed). I also implemented another command "Git Graph: End a specific Code Review in Workspace..." that behaves equivalently for ending a specific code review.

Visual Studio Code does not provide a suitable UI element for just showing a list of items without them being selectable, so I didn't implement a separate "List All Code Reviews" command. Since there is now resume and end commands, I think most users wouldn't have a need to just view a list of code reviews, without wanting to resume or end one. If the user does just want to check if any code reviews are in progress, they could always just run the resume command to see the list, then press escape to exit the list (and not proceed with resuming). If after the release I get feedback that indicates a list command would also be used, I'd be happy to add it in the following release.

This will be available in v1.22.0.

If you'd like to use it before the next release, you can download v1.22.0-beta.1, and install it following the instructions provided here.

Sweet 👍 thanks very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement An improvement to existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants