Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find results are not visible in high contrast themes #363

Closed
Sesostrismage opened this issue Aug 11, 2020 · 3 comments
Closed

Find results are not visible in high contrast themes #363

Sesostrismage opened this issue Aug 11, 2020 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Sesostrismage
Copy link

When I use the Git Graph find dialog with e.g. the tomorrow night theme, the find result for "formatting" looks like this and is visible in the graph:
Find - Tomorrow night theme

When I use the built-in high contrast theme and another high-contrast theme I have installed, the find result is invisible:
Find - High contrast theme

@Sesostrismage Sesostrismage added the bug Something isn't working label Aug 11, 2020
@mhutchie
Copy link
Owner

Hi @Sesostrismage,

Thanks for making me aware of this incompatibility with high contrast themes. From what I can see, unlike light and dark themes, high contrast themes only specify a border colour (no background colour) for find matches.

Git Graph currently consumes the Visual Studio Code CSS Property --vscode-editor-findMatchHighlightBackground to style find matches. As this is not defined in high contrast themes, that is why no highlighting is currently shown for find matches.

I'll adjust the styling of find matches to use an outline of the Visual Studio Code CSS Property --vscode-editor-findMatchHighlightBorder, so that matches can be seen in high contrast themes.

@mhutchie mhutchie added this to the v1.26.0 milestone Aug 11, 2020
@mhutchie
Copy link
Owner

This will be available in v1.26.0.

If you'd like to use it before the next release, you can download v1.26.0-beta.2, and install it following the instructions provided here.

@Sesostrismage
Copy link
Author

Thank you for the fast response, much appreciated. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants