Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): response code for index conflict #140

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

hiimjako
Copy link
Contributor

Pull Request Type

  • Bugfix

Description

Changed the return status code in case of unique index violation, from 422 to a more appropriate 409.
This should be included in a major release

PR Checklist

  • The commit message follows our guidelines included in the CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@hiimjako hiimjako self-assigned this Jul 19, 2023
@hiimjako hiimjako requested a review from ThisIsDemetrio July 20, 2023 07:49
@danibix95 danibix95 added breaking For changes that might break service behavior next_major labels Jul 20, 2023
hiimjako and others added 3 commits September 8, 2023 16:32
@danibix95 danibix95 force-pushed the fix/conflict-status-code branch from 19a358b to 5f95d6b Compare September 8, 2023 14:35
@danibix95 danibix95 merged commit 7d0b0a6 into main Sep 8, 2023
@danibix95 danibix95 deleted the fix/conflict-status-code branch September 8, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking For changes that might break service behavior next_major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants