Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move load models codebase #226

Merged
merged 3 commits into from
Nov 22, 2023
Merged

refactor: move load models codebase #226

merged 3 commits into from
Nov 22, 2023

Conversation

fredmaggiowski
Copy link
Member

Pull Request Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Description

Moved loadModels contents in its own file in order to reduce index codebase

PR Checklist

  • The commit message follows our guidelines included in the CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@fredmaggiowski fredmaggiowski changed the title Refactor/move load models codebase refactor: move load models codebase Nov 22, 2023
@fredmaggiowski fredmaggiowski changed the base branch from main to v6.x November 22, 2023 11:23
@fredmaggiowski fredmaggiowski marked this pull request as ready for review November 22, 2023 11:24
danibix95
danibix95 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@danibix95 danibix95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danibix95 danibix95 merged commit 8b19b20 into v6.x Nov 22, 2023
@danibix95 danibix95 deleted the refactor/move-loadModels-codebase branch November 22, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danibix95 danibix95 danibix95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredmaggiowski @danibix95