Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve export and ensure columns order #255

Merged
merged 5 commits into from
Jan 22, 2024

Conversation

fredmaggiowski
Copy link
Member

Pull Request Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Description

This PR introduces an improvement to the export routine in order to enforce column ordering.

Might be seen both as an improvement or a bugfix since relying on the first document may cause undefined behaviours as we already discussed here

PR Checklist

  • The commit message follows our guidelines included in the CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR introduce a breaking change?

  • Yes
  • No

@danibix95 danibix95 merged commit 7d9e74d into v6.x Jan 22, 2024
9 checks passed
@danibix95 danibix95 deleted the fix/improve-export-with-columns-managemet branch January 22, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants