Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export test utils #311

Merged
merged 2 commits into from
Feb 16, 2024
Merged

feat: export test utils #311

merged 2 commits into from
Feb 16, 2024

Conversation

Giogia
Copy link
Contributor

@Giogia Giogia commented Feb 13, 2024

Description

Exported testing utils to help wrap components with theme configuration in tests.

Checklist

  • added the link to the Jira task
  • commit message and branch name follow conventions
  • tests are included
  • changes are accessible and documented from components stories
  • typings are updated or integrated accordingly with your changes
  • all added components are exported from index file (if necessary)
  • all added files include Apache 2.0 license
  • you are not committing extraneous files or sensible data
  • the browser console does not have any logged errors
  • necessary labels have been applied to this pull request (enhancement, bug, ecc.)

@Giogia Giogia requested a review from a team as a code owner February 13, 2024 16:56
@Giogia Giogia self-assigned this Feb 13, 2024
@Giogia Giogia added the enhancement New feature or request label Feb 13, 2024
@Giogia Giogia changed the title fix: export test utils feat: export test utils Feb 14, 2024
fredmaggiowski
fredmaggiowski approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@fredmaggiowski fredmaggiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Danielecina Danielecina merged commit eeddc96 into main Feb 16, 2024
6 checks passed
@Danielecina Danielecina deleted the fix/export-test-utils branch February 16, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredmaggiowski fredmaggiowski fredmaggiowski approved these changes

@Danielecina Danielecina Danielecina approved these changes

@RiccardoCorona-MiaPlatform RiccardoCorona-MiaPlatform Awaiting requested review from RiccardoCorona-MiaPlatform

Assignees

@Giogia Giogia

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Giogia @fredmaggiowski @Danielecina