Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drawer footer standard props and some improvements #532

Merged
merged 14 commits into from
Jul 12, 2024
Merged

feat: drawer footer standard props and some improvements #532

merged 14 commits into from
Jul 12, 2024

Conversation

GiovannaMonti
Copy link
Contributor

@GiovannaMonti GiovannaMonti commented Jul 11, 2024 •
edited
Loading

Description

This PR follows the Drawer component introduction PR and introduces the following changes:

Drawer component

New features:

  • Drawer footer can now be a custom node or can leverage standard properties (button, extra) for a predefined look.
  • Drawer now has a closeIcon
  • Drawer can now display a doc link

Improvements:

  • Drawer types have been moved to a separate file
  • Drawer stories and mocks have been refactored to be more meaningful and usable; Drawer stories now correctly show the drawer props in the Show Code tab
  • Drawer styles are now imported from a CSS module

Checklist

  • commit message and branch name follow conventions
  • tests are included
  • changes are accessible and documented from components stories
  • typings are updated or integrated accordingly with your changes
  • all added components are exported from index file (if necessary)
  • all added files include Apache 2.0 license
  • you are not committing extraneous files or sensitive data
  • the browser console does not have any logged errors
  • necessary labels have been applied to this pull request (enhancement, bug, ecc.)

@GiovannaMonti GiovannaMonti added Button component Button component and hooks related activities Drawer component Drawer component and hooks related activities labels Jul 11, 2024
@GiovannaMonti GiovannaMonti requested a review from a team as a code owner July 11, 2024 15:59
MIA-Deltat1995
MIA-Deltat1995 previously approved these changes Jul 11, 2024
View reviewed changes
@GiovannaMonti GiovannaMonti marked this pull request as draft July 11, 2024 16:40
@epessina
Copy link
Contributor

Can we consider adding a docLink prop to show the doc icon in the title like in the Modal?

@GiovannaMonti GiovannaMonti self-assigned this Jul 12, 2024
@GiovannaMonti GiovannaMonti marked this pull request as ready for review July 12, 2024 08:01
@fredmaggiowski
Copy link
Member

Can we consider adding a docLink prop to show the doc icon in the title like in the Modal?

This makes sense, do other components have a standard prop definition for this? If so let's do this following the same prop-defnition, if not I'd open a PR to define such standard prop and then open another PR

fredmaggiowski
fredmaggiowski previously approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@fredmaggiowski fredmaggiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GiovannaMonti GiovannaMonti removed the Button component Button component and hooks related activities label Jul 12, 2024
@GiovannaMonti
Copy link
Contributor Author

Can we consider adding a docLink prop to show the doc icon in the title like in the Modal?

Can we consider adding a docLink prop to show the doc icon in the title like in the Modal?

This makes sense, do other components have a standard prop definition for this? If so let's do this following the same prop-defnition, if not I'd open a PR to define such standard prop and then open another PR

yes, the Modal has it. I can add it

@GiovannaMonti GiovannaMonti changed the title feat: drawer footer standard props feat: drawer footer standard props and some improvements Jul 12, 2024
fredmaggiowski
fredmaggiowski approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@fredmaggiowski fredmaggiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredmaggiowski fredmaggiowski merged commit 1093548 into main Jul 12, 2024
6 checks passed
@fredmaggiowski fredmaggiowski deleted the feat/add-drawer-footer-standard-props branch July 12, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredmaggiowski fredmaggiowski fredmaggiowski approved these changes

@MIA-Deltat1995 MIA-Deltat1995 MIA-Deltat1995 left review comments

Assignees

@GiovannaMonti GiovannaMonti

Labels
Drawer component Drawer component and hooks related activities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GiovannaMonti @epessina @fredmaggiowski @MIA-Deltat1995