Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(Badge): Added hasMultilineDescription prop to badge #816

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

nicmell
Copy link
Contributor

@nicmell nicmell commented Jan 31, 2025

Added prop hasMultilineDescription to Badge

Added the prop hasMultilineDescription to Badge: by default the description is clipped and ellipsis is shown, but in some cases is desirable to have text falling back to the next line.

Screenshot 2025-01-31 alle 11 32 36
Badge
- Added prop hasMultilineDescription to Badge

[IMPORTANT] PR Checklist

  • I am aware of standards and conventions adopted in this repository, defined in the CONTRIBUTING.md file

PR conventions

Please make sure your PR complies with the following rules before submitting it.

  • PR title follows the <type>(<scope>): <subject> structure

  • The PR has been labeled according to the type of changes (e.g. enhancement, new component, bug).

    NOTE
    Some labels are used to generate release note entries: you can find the complete mapping between PR labels and release note categories here.
    For a more detailed overview of PR labels, please refer to the dedicated CONTRIBUTING section.

Additional code checks

Based on your changes, some of these checks may not apply. Please make sure to check the relevant items in the list.

  • Changes are covered by tests
  • Changes to components are accessible and documented in the Storybook
  • Typings have been updated
  • New components are exported from the src/index.ts file
  • New files include the Apache 2.0 License disclaimer
  • The browser console does not contain errors

@nicmell nicmell added enhancement New feature or request Badge component labels Jan 31, 2025
@nicmell nicmell requested a review from a team as a code owner January 31, 2025 10:33
@nicmell nicmell changed the title Feat(Badge): Added multiline prop to badge Feat(Badge): Added hasMultilineDescription prop to badge Jan 31, 2025
@fredmaggiowski fredmaggiowski merged commit 250c77b into main Feb 5, 2025
6 checks passed
@fredmaggiowski fredmaggiowski deleted the feat/multiline-badge branch February 5, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Badge component enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants