Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add platformio known issues to Readme #849

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Add platformio known issues to Readme #849

merged 2 commits into from
Mar 18, 2022

Conversation

Acuadros95
Copy link
Contributor

@Acuadros95 Acuadros95 commented Mar 18, 2022 •
edited
Loading

TODO: Backport without multiple definition of Link errors on galactic section

@Acuadros95 Acuadros95 requested a review from pablogs9 March 18, 2022 11:31
@Acuadros95
Copy link
Contributor Author

Please @amilcarlucas give your thoughts

@Acuadros95 Acuadros95 mentioned this pull request Mar 18, 2022
Closed
pablogs9
pablogs9 approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@pablogs9 pablogs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Acuadros95
Copy link
Contributor Author

@mergify backport main foxy

@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2022

backport main foxy

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

Hey, I reacted but my real name is @Mergifyio

@pablogs9
Copy link
Member

Do we need this in galactic and foxy?

@Acuadros95
Copy link
Contributor Author

Acuadros95 commented Mar 18, 2022 •
edited
Loading

On rolling and foxy we don't need the linker modifications, but the rest of issues still apply
I will modify the text on the backports to leave only relevant issues.

@amilcarlucas
Copy link
Contributor

Yes, I like the way you changed it. Thanks for following up on this.

@Acuadros95 Acuadros95 merged commit 08c0e7d into galactic Mar 18, 2022
@Acuadros95 Acuadros95 deleted the doc/platformio branch March 18, 2022 12:37
mergify bot pushed a commit that referenced this pull request Mar 18, 2022
@Acuadros95
Add platformio known issues to Readme (#849)
b110746 
* Add platformio known issues to Readme

* Fix ident

(cherry picked from commit 08c0e7d)
@mergify mergify bot mentioned this pull request Mar 18, 2022
Merged
mergify bot pushed a commit that referenced this pull request Mar 18, 2022
@Acuadros95
Add platformio known issues to Readme (#849)
ee63a1c 
* Add platformio known issues to Readme

* Fix ident

(cherry picked from commit 08c0e7d)
@mergify mergify bot mentioned this pull request Mar 18, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2022

backport main foxy

✅ Backports have been created

pablogs9 pushed a commit that referenced this pull request Mar 18, 2022
@mergify @Acuadros95
Add platformio known issues to Readme (backport #849) (#851)
d2ab741 
* Add platformio known issues to Readme (#849)

* Add platformio known issues to Readme

* Fix ident

(cherry picked from commit 08c0e7d)

* Remove galactic issues

Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
Co-authored-by: acuadros95 <acuadros1995@gmail.com>
Acuadros95 added a commit that referenced this pull request Mar 18, 2022
@mergify @Acuadros95
Add platformio known issues to Readme (backport #849) (#850)
8866484 
* Add platformio known issues to Readme (#849)

* Add platformio known issues to Readme

* Fix ident

(cherry picked from commit 08c0e7d)

* Remove galactic issues

Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
Co-authored-by: acuadros95 <acuadros1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogs9 pablogs9 pablogs9 approved these changes

@amilcarlucas amilcarlucas amilcarlucas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Acuadros95 @pablogs9 @amilcarlucas