-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rel=tag hentry/hreview backcompat #164
Conversation
Update existing tests to verify rel-tag upgrade
I still have to read up on how php-mf2 actually handles backwards compatibility parsing but this looks like a good way to rewrite the One thing that comes to mind – but may already apply to other back-compat work – is what happens if the link is inside an element that will be parsed as an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zegnat makes a good point. Currently this ends up inserting the data element into the content HTML and text. I've added a failing test and sent it as a PR against your branch. If you merge gRegorLove#2 then this PR will be updated with the failing test.
add failing test for excluding the generated data element in rel tag backcompat
Fixed test to include the original rel=tag HTML/text
If the test can be rerun and it turns out it passes I say lets merge this 👍 One downside discussed on IRC seems to be fringe and not worth fretting over for now. Maybe?
|
Fixes #157