Better inval #976
Merged
Better inval #976
+1,482
−1,441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChumpChief
previously approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Love the improvements in item counter - brainstorm is still doing an invalidations-like approach in a few places which would be good to try to get away from if you can. Overall these are improvements though so I'm going ahead with approval, lmk if you'd like me to take another look later.
| </div> | ||
| <Explanation /> | ||
| </div> | ||
| ); | ||
| } | ||
|
|
||
| export function ListGroup(props: { list: StringArray }): JSX.Element { | ||
| const [count, setCount] = useState(props.list.length); |
There was a problem hiding this comment.
Nit, it's nice to deconstruct the props at the top for less repetition
const { list } = props;
ChumpChief
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.