Show progress dialog during startup #9255

chrdavis · 2021-01-24T06:20:27Z

This change adds a standard shell progress dialog during startup to give feedback to the user that we are gathering all the items that were selected (including items in subfolders). This allows the user to know we are still doing work as well as provide a means to cancel the operation.

Applies to #9254

…n take a long time.

github-actions · 2021-01-24T07:07:56Z

New misspellings found, please review:

IProgress
MARQUEEPROGRESS
PROGDLG
sppd

To accept these changes, run the following commands

perl -e '
my @expect_files=qw('".github/actions/spell-check/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"HKE QWORD Runtimes Segoe "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^($re)(?:$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spell-check/expect.txt";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"IProgress MARQUEEPROGRESS PROGDLG qword runtimes segoe sppd "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
git add .github/actions/spell-check || echo '... you want to ensure .github/actions/spell-check/expect.txt is added to your repository...'

htcfreek · 2021-01-24T07:33:52Z

@chrdavis
Can you chage the word "fixes" to "Applies to". We don't use the wording "fixes" to not auto close the issue.

chrdavis · 2021-01-25T03:57:43Z

@chrdavis
Can you chage the word "fixes" to "Applies to". We don't use the wording "fixes" to not auto close the issue.

Done

chrdavis · 2021-01-27T17:34:09Z

Any update on this review?

enricogior · 2021-01-29T10:05:06Z

@chrdavis
is it expected that the progress dialog stays open for about 1 second after the PowerRename dialog opens?

chrdavis · 2021-01-29T18:26:19Z

@chrdavis
is it expected that the progress dialog stays open for about 1 second after the PowerRename dialog opens?

The progress dialog should show only after a delay of a few seconds. Perhaps I can wrap this in a better delay of my own on top of that.

chrdavis · 2021-02-12T06:21:11Z

I updated SmartRename with a progress dialog that takes into account ~ 3s before being shown. I'll let that get downloaded and used then port it here.

enricogior · 2021-02-12T09:09:20Z

@chrdavis
what should we do with the current PR?

…ess dialog does not appear in most cases.

chrdavis · 2021-02-13T05:48:32Z

@chrdavis
what should we do with the current PR?

I ported the changes. Please review when you get a chance.

github-actions · 2021-02-13T06:36:47Z

New misspellings found, please review:

IProgress
ISmart
MARQUEEPROGRESS
PROGDLG
sppd
sppre
ULONGLONG

To accept these changes, run the following commands

perl -e '
my @expect_files=qw('".github/actions/spell-check/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"HKE Oject QWORD Runtimes Segoe "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^($re)(?:$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spell-check/expect.txt";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"IProgress ISmart MARQUEEPROGRESS PROGDLG qword runtimes segoe sppd sppre ULONGLONG "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
git add .github/actions/spell-check || echo '... you want to ensure .github/actions/spell-check/expect.txt is added to your repository...'

enricogior · 2021-02-17T10:26:05Z

@chrdavis
I tested the updated version and it looks like the progress bar is slowing down the file processing.
I used the repository folders so it's easy to replicate.
When renaming individual folders, it take in total 3-4 seconds.
But when renaming the folders together, the progress bar shows up and it takes over 10 seconds.
The overhead introduced by the progress bar keep increasing for larger folders.
I would guess that the problem is caused by updating the progress bar with the filenames, can the progress bar just show the bar and not the filenames?
Also, it takes about 3 seconds for the progress bar to show, what about lowering to 2 seconds or even 1.5 seconds?

chrdavis · 2021-02-18T01:12:11Z

Updated based on the feedback. The updating of the progress dialog is replaced with a static message now so the slowdown should go away. I also changed the delay from 3s to 1.5s.

github-actions · 2021-02-18T01:57:18Z

New misspellings found, please review:

IProgress
ISmart
MARQUEEPROGRESS
PROGDLG
sppd
sppre
ULONGLONG

To accept these changes, run the following commands

perl -e '
my @expect_files=qw('".github/actions/spell-check/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"HKE Oject QWORD Runtimes Segoe "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^($re)(?:$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spell-check/expect.txt";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"IProgress ISmart MARQUEEPROGRESS PROGDLG qword runtimes segoe sppd sppre ULONGLONG "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
git add .github/actions/spell-check || echo '... you want to ensure .github/actions/spell-check/expect.txt is added to your repository...'

crutkas · 2021-02-24T21:51:09Z

@enricogior any reason why this can't be in?

enricogior · 2021-02-24T22:01:09Z

@crutkas
it is still not working for me, after the last change, the progress dialog appears after the PowerRename dialog is shown.

chrdavis · 2021-02-25T07:34:26Z

@crutkas
it is still not working for me, after the last change, the progress dialog appears after the PowerRename dialog is shown.

Really? Can you post a gif?

chrdavis · 2021-02-26T08:27:24Z

I just updated the timeout from 1500ms to 2500ms. Originally it was 3000ms.

enricogior · 2021-02-26T08:35:39Z

@chrdavis
this was before your last commit:

I'll rebuild it and test it again

github-actions · 2021-02-26T08:39:28Z

New misspellings found, please review:

IProgress
ISmart
MARQUEEPROGRESS
PROGDLG
sppd
sppre
ULONGLONG

To accept these changes, run the following commands

perl -e '
my @expect_files=qw('".github/actions/spell-check/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"HKE Oject QWORD Runtimes Segoe "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^($re)(?:$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spell-check/expect.txt";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"IProgress ISmart MARQUEEPROGRESS PROGDLG qword runtimes segoe sppd sppre ULONGLONG "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
git add .github/actions/spell-check || echo '... you want to ensure .github/actions/spell-check/expect.txt is added to your repository...'

enricogior · 2021-02-26T08:40:49Z

@chrdavis
same behavior using the latest bits:

chrdavis · 2021-02-26T17:27:20Z

Yeah, we are competing on the UI thread. I'll need to shuffle some things around. I'll have an update next week.

chrdavis · 2021-03-02T05:19:55Z

Updated once again. Progress UI is now invoked on a background thread. No longer need the delay timer for the progress dialog. Please try this out.

github-actions · 2021-03-02T05:34:13Z

New misspellings found, please review:

CHECKCANCELED
IProgress
ISmart
MARQUEEPROGRESS
PROGDLG
prpui
sppd
sppre
TIMERID

To accept these changes, run the following commands

perl -e '
my @expect_files=qw('".github/actions/spell-check/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"HKE Oject QWORD Runtimes Segoe "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^($re)(?:$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spell-check/expect.txt";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"CHECKCANCELED IProgress ISmart MARQUEEPROGRESS PROGDLG prpui qword runtimes segoe sppd sppre TIMERID "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
git add .github/actions/spell-check || echo '... you want to ensure .github/actions/spell-check/expect.txt is added to your repository...'

chrdavis · 2021-03-29T20:38:58Z

@crutkas Is this tested and good to go for next release?

crutkas · 2021-03-30T02:22:27Z

@enricogior assuming won't happen for 35 due to time. What needs to happen to review here.

enricogior · 2021-03-30T09:17:27Z

@crutkas @chrdavis
I'll review it after 0.35 is released.

enricogior · 2021-04-02T10:06:44Z

@chrdavis
tested, it works as expected, thanks for making it perfectly smooth!

Show progress dialog during startup for selection enumeration that ca…

4ff6ac8

…n take a long time.

chrdavis linked an issue Jan 24, 2021 that may be closed by this pull request

PowerRename should add progress dialog during startup #9254

Closed

htcfreek mentioned this pull request Jan 25, 2021

[Github > msftbot] Bot react on keyword "fixes" but not on "applies to" #9282

Closed

enricogior added the Product-PowerRename label Jan 27, 2021

Updated with better code organization and a timer to ensure the progr…

f2fdd99

…ess dialog does not appear in most cases.

Update based on PR feedback

bef782a

Change progress dialog delay from 1500ms to 2500ms

6a97ddc

Move progress dialog invocation off the main UI thread

cb4e291

enricogior approved these changes Apr 2, 2021

View reviewed changes

enricogior merged commit d128939 into microsoft:master Apr 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show progress dialog during startup #9255

Show progress dialog during startup #9255

chrdavis commented Jan 24, 2021 •

edited

Loading

github-actions bot commented Jan 24, 2021

htcfreek commented Jan 24, 2021

chrdavis commented Jan 25, 2021

chrdavis commented Jan 27, 2021

enricogior commented Jan 29, 2021

chrdavis commented Jan 29, 2021

chrdavis commented Feb 12, 2021

enricogior commented Feb 12, 2021

chrdavis commented Feb 13, 2021

github-actions bot commented Feb 13, 2021

enricogior commented Feb 17, 2021

chrdavis commented Feb 18, 2021

github-actions bot commented Feb 18, 2021

crutkas commented Feb 24, 2021

enricogior commented Feb 24, 2021

chrdavis commented Feb 25, 2021

chrdavis commented Feb 26, 2021

enricogior commented Feb 26, 2021

github-actions bot commented Feb 26, 2021

enricogior commented Feb 26, 2021

chrdavis commented Feb 26, 2021

chrdavis commented Mar 2, 2021

github-actions bot commented Mar 2, 2021

chrdavis commented Mar 29, 2021

crutkas commented Mar 30, 2021

enricogior commented Mar 30, 2021

enricogior commented Apr 2, 2021

Show progress dialog during startup #9255

Show progress dialog during startup #9255

Conversation

chrdavis commented Jan 24, 2021 • edited Loading

github-actions bot commented Jan 24, 2021

New misspellings found, please review:

htcfreek commented Jan 24, 2021

chrdavis commented Jan 25, 2021

chrdavis commented Jan 27, 2021

enricogior commented Jan 29, 2021

chrdavis commented Jan 29, 2021

chrdavis commented Feb 12, 2021

enricogior commented Feb 12, 2021

chrdavis commented Feb 13, 2021

github-actions bot commented Feb 13, 2021

New misspellings found, please review:

enricogior commented Feb 17, 2021

chrdavis commented Feb 18, 2021

github-actions bot commented Feb 18, 2021

New misspellings found, please review:

crutkas commented Feb 24, 2021

enricogior commented Feb 24, 2021

chrdavis commented Feb 25, 2021

chrdavis commented Feb 26, 2021

enricogior commented Feb 26, 2021

github-actions bot commented Feb 26, 2021

New misspellings found, please review:

enricogior commented Feb 26, 2021

chrdavis commented Feb 26, 2021

chrdavis commented Mar 2, 2021

github-actions bot commented Mar 2, 2021

New misspellings found, please review:

chrdavis commented Mar 29, 2021

crutkas commented Mar 30, 2021

enricogior commented Mar 30, 2021

enricogior commented Apr 2, 2021

chrdavis commented Jan 24, 2021 •

edited

Loading