-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add promise.any #33844
add promise.any #33844
Conversation
7ee1d7f
to
708449f
Compare
708449f
to
d5160d1
Compare
20c3784
to
0f8f9f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kingwl This looks good; I'll merge it as soon as you update the jsdoc. (I'm not sure my suggestion is the best -- it might be possible to condense the wording overall.)
Co-Authored-By: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
A baseline needed to be updated after the merge from master. I'll merge this after CI finishes running. |
Hi, I am able to compile successfully but at runtime, I receive a
Any feedback would be much appreciated. |
same with me. typescript 3.9.7 |
@mt-yannick @alongite what VM are you using? I looked at https://caniuse.com/#search=Promise.any and it's only on recent versions of Chrome and Firefox as far as I can tell. It's not in Node 14 yet. |
@sandersn Oh! Thank you for clarifying!! So if I understand correctly, this PR implements the types for |
@mt-yannick yes, that's exactly right. Stuff in |
Fixes #33843
BTW: #31085