Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactable parameter inlay hints #54734

Merged
merged 12 commits into from
Jul 20, 2023
Merged

Interactable parameter inlay hints #54734

merged 12 commits into from
Jul 20, 2023

Conversation

MariaSolOs
Copy link
Contributor

@MariaSolOs MariaSolOs commented Jun 21, 2023 •
edited
Loading

Part of #47693. This first iteration adds "go to definition" support for parameter inlay hints.

@typescript-bot
Copy link
Collaborator

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @mjbvz, @zkat, and @joj for you. Feel free to loop in other consumers/maintainers if necessary

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 21, 2023
@MariaSolOs MariaSolOs marked this pull request as draft June 21, 2023 20:47
mjbvz
mjbvz approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Protocol parts of the change look good to me. Thank you for looking into this!

@MariaSolOs MariaSolOs mentioned this pull request Jun 30, 2023
Merged
@typescript-bot
Copy link
Collaborator

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

@BobbyJonas
Copy link

🎉Added to my watch list. Hope to use the feature asap

@MariaSolOs MariaSolOs changed the title Interactable inlay hints Interactable parameter inlay hints Jul 10, 2023
@MariaSolOs MariaSolOs marked this pull request as ready for review July 10, 2023 21:09
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@MariaSolOs MariaSolOs merged commit 9731010 into microsoft:main Jul 20, 2023
@jakebailey jakebailey mentioned this pull request Jul 26, 2023
Closed
@mjbvz mjbvz mentioned this pull request Jul 31, 2023
Merged
@MariaSolOs MariaSolOs deleted the inlay-hints-wow branch August 1, 2023 21:23
@jakebailey jakebailey mentioned this pull request Aug 4, 2023
Merged
@luabud luabud mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser left review comments

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

@mjbvz mjbvz mjbvz approved these changes

@gabritto gabritto gabritto approved these changes

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

Assignees

@MariaSolOs MariaSolOs

Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MariaSolOs @typescript-bot @BobbyJonas @DanielRosenwasser @RyanCavanaugh @mjbvz @gabritto