Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate object flags related to object and array literals onto module.exports types #57467

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Propagate object flags related to object and array literals onto module.exports types #57467

merged 3 commits into from
Apr 16, 2024

Conversation

Andarist
Copy link
Contributor

fixes #57460

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Feb 21, 2024
@Andarist Andarist mentioned this pull request Feb 21, 2024
Closed
@Andarist Andarist marked this pull request as ready for review February 21, 2024 23:04
@sandersn sandersn requested review from sandersn and gabritto March 8, 2024 23:02
@typescript-bot typescript-bot removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 8, 2024
@typescript-bot typescript-bot added For Backlog Bug PRs that fix a backlog bug labels Mar 8, 2024
@gabritto
Copy link
Member

gabritto commented Apr 5, 2024

@typescript-bot test it

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 5, 2024 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started 👀 Results
user test this ✅ Started 👀 Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

Hey @gabritto, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Collaborator

@gabritto
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Angular - node (v18.15.0, x64)
Memory used 295,527k (± 0.01%) 295,528k (± 0.00%) ~ 295,522k 295,544k p=0.936 n=6
Parse Time 2.66s (± 0.24%) 2.66s (± 0.15%) ~ 2.65s 2.66s p=0.673 n=6
Bind Time 0.83s (± 0.49%) 0.83s (± 0.99%) ~ 0.82s 0.84s p=0.584 n=6
Check Time 8.21s (± 0.54%) 8.21s (± 0.24%) ~ 8.18s 8.24s p=0.572 n=6
Emit Time 7.03s (± 0.23%) 7.05s (± 0.30%) ~ 7.03s 7.09s p=0.167 n=6
Total Time 18.73s (± 0.20%) 18.74s (± 0.14%) ~ 18.70s 18.77s p=0.333 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used 193,105k (± 1.01%) 192,467k (± 0.76%) ~ 191,830k 195,443k p=0.810 n=6
Parse Time 1.36s (± 1.04%) 1.36s (± 0.80%) ~ 1.35s 1.38s p=1.000 n=6
Bind Time 0.72s (± 0.57%) 0.72s (± 0.00%) ~ 0.72s 0.72s p=0.405 n=6
Check Time 9.52s (± 0.75%) 9.44s (± 0.27%) -0.09s (- 0.89%) 9.40s 9.48s p=0.015 n=6
Emit Time 2.63s (± 0.54%) 2.63s (± 0.42%) ~ 2.61s 2.64s p=1.000 n=6
Total Time 14.23s (± 0.48%) 14.15s (± 0.26%) -0.08s (- 0.57%) 14.11s 14.21s p=0.030 n=6
Monaco - node (v18.15.0, x64)
Memory used 347,368k (± 0.01%) 347,391k (± 0.01%) ~ 347,358k 347,424k p=0.173 n=6
Parse Time 2.49s (± 0.30%) 2.48s (± 0.84%) ~ 2.45s 2.50s p=0.741 n=6
Bind Time 0.92s (± 0.59%) 0.93s (± 0.44%) ~ 0.92s 0.93s p=0.282 n=6
Check Time 7.01s (± 0.62%) 7.01s (± 0.52%) ~ 6.96s 7.05s p=0.809 n=6
Emit Time 4.06s (± 0.30%) 4.07s (± 0.49%) ~ 4.03s 4.08s p=0.343 n=6
Total Time 14.49s (± 0.27%) 14.48s (± 0.38%) ~ 14.38s 14.54s p=0.571 n=6
TFS - node (v18.15.0, x64)
Memory used 302,714k (± 0.00%) 302,711k (± 0.01%) ~ 302,686k 302,745k p=0.470 n=6
Parse Time 2.00s (± 0.98%) 2.02s (± 0.51%) ~ 2.01s 2.04s p=0.050 n=6
Bind Time 1.00s (± 0.41%) 1.01s (± 1.49%) ~ 0.99s 1.03s p=0.849 n=6
Check Time 6.31s (± 0.51%) 6.32s (± 0.45%) ~ 6.28s 6.36s p=0.872 n=6
Emit Time 3.61s (± 0.41%) 3.61s (± 0.46%) ~ 3.58s 3.62s p=1.000 n=6
Total Time 12.93s (± 0.32%) 12.96s (± 0.21%) ~ 12.92s 12.99s p=0.255 n=6
material-ui - node (v18.15.0, x64)
Memory used 509,882k (± 0.01%) 509,893k (± 0.00%) ~ 509,869k 509,911k p=0.689 n=6
Parse Time 2.66s (± 0.51%) 2.66s (± 0.19%) ~ 2.66s 2.67s p=0.386 n=6
Bind Time 0.98s (± 0.85%) 0.99s (± 0.99%) ~ 0.98s 1.00s p=0.256 n=6
Check Time 17.26s (± 0.52%) 17.25s (± 0.40%) ~ 17.13s 17.32s p=0.936 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 20.90s (± 0.42%) 20.91s (± 0.33%) ~ 20.79s 20.99s p=0.810 n=6
mui-docs - node (v18.15.0, x64)
Memory used 1,744,093k (± 0.00%) 1,744,071k (± 0.00%) ~ 1,744,040k 1,744,088k p=0.423 n=6
Parse Time 9.64s (± 0.36%) 9.66s (± 0.62%) ~ 9.59s 9.76s p=0.571 n=6
Bind Time 3.46s (± 1.03%) 3.49s (± 0.42%) +0.04s (+ 1.06%) 3.47s 3.51s p=0.042 n=6
Check Time 81.86s (± 0.58%) 81.73s (± 0.52%) ~ 81.29s 82.49s p=0.689 n=6
Emit Time 0.20s (± 2.62%) 0.19s (± 2.81%) ~ 0.19s 0.20s p=0.640 n=6
Total Time 95.14s (± 0.51%) 95.07s (± 0.46%) ~ 94.59s 95.82s p=0.810 n=6
self-build-src - node (v18.15.0, x64)
Memory used 2,393,739k (± 0.01%) 2,394,500k (± 0.02%) +761k (+ 0.03%) 2,393,631k 2,395,061k p=0.031 n=6
Parse Time 7.50s (± 1.00%) 7.57s (± 0.76%) ~ 7.49s 7.64s p=0.128 n=6
Bind Time 2.76s (± 0.61%) 2.78s (± 1.31%) ~ 2.74s 2.84s p=0.258 n=6
Check Time 49.10s (± 0.18%) 48.94s (± 0.54%) ~ 48.57s 49.19s p=0.378 n=6
Emit Time 3.91s (± 1.07%) 3.85s (± 1.42%) ~ 3.76s 3.92s p=0.077 n=6
Total Time 63.27s (± 0.18%) 63.16s (± 0.38%) ~ 62.84s 63.41s p=0.575 n=6
self-build-src-public-api - node (v18.15.0, x64)
Memory used 0k 0k ~ 0k 0k p=NaN n=0
Parse Time 0.00s 0.00s ~ 0.00s 0.00s p=NaN n=0
Bind Time 0.00s 0.00s ~ 0.00s 0.00s p=NaN n=0
Check Time 0.00s 0.00s ~ 0.00s 0.00s p=NaN n=0
Emit Time 0.00s 0.00s ~ 0.00s 0.00s p=NaN n=0
Total Time 0.00s 0.00s ~ 0.00s 0.00s p=NaN n=0
self-compiler - node (v18.15.0, x64)
Memory used 415,219k (± 0.01%) 415,199k (± 0.01%) ~ 415,132k 415,248k p=0.471 n=6
Parse Time 4.21s (± 0.83%) 4.24s (± 0.41%) ~ 4.22s 4.27s p=0.171 n=6
Bind Time 1.59s (± 0.53%) 1.58s (± 1.35%) ~ 1.55s 1.61s p=0.732 n=6
Check Time 22.33s (± 0.26%) 22.31s (± 0.24%) ~ 22.24s 22.39s p=0.630 n=6
Emit Time 1.65s (± 2.34%) 1.65s (± 1.46%) ~ 1.64s 1.70s p=0.934 n=6
Total Time 29.78s (± 0.24%) 29.79s (± 0.29%) ~ 29.69s 29.90s p=1.000 n=6
vscode - node (v18.15.0, x64)
Memory used 2,904,319k (± 0.00%) 2,904,398k (± 0.00%) ~ 2,904,262k 2,904,453k p=0.173 n=6
Parse Time 12.95s (± 0.40%) 12.93s (± 0.58%) ~ 12.81s 13.04s p=0.377 n=6
Bind Time 4.15s (± 0.78%) 4.15s (± 0.30%) ~ 4.13s 4.16s p=0.682 n=6
Check Time 72.45s (± 0.37%) 72.00s (± 0.54%) ~ 71.58s 72.50s p=0.066 n=6
Emit Time 22.06s (± 8.53%) 20.11s (± 8.19%) ~ 19.37s 23.48s p=0.065 n=6
Total Time 111.61s (± 1.72%) 109.19s (± 1.71%) -2.42s (- 2.17%) 108.17s 112.96s p=0.045 n=6
webpack - node (v18.15.0, x64)
Memory used 408,327k (± 0.01%) 408,322k (± 0.01%) ~ 408,268k 408,358k p=1.000 n=6
Parse Time 3.24s (± 0.54%) 3.25s (± 0.54%) ~ 3.22s 3.27s p=0.867 n=6
Bind Time 1.39s (± 1.27%) 1.39s (± 1.06%) ~ 1.37s 1.41s p=0.803 n=6
Check Time 14.21s (± 0.23%) 14.20s (± 0.37%) ~ 14.14s 14.28s p=0.872 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 18.84s (± 0.25%) 18.84s (± 0.30%) ~ 18.78s 18.93s p=0.936 n=6
xstate - node (v18.15.0, x64)
Memory used 513,059k (± 0.01%) 513,029k (± 0.02%) ~ 512,930k 513,128k p=0.575 n=6
Parse Time 3.29s (± 0.23%) 3.29s (± 0.30%) ~ 3.27s 3.30s p=0.858 n=6
Bind Time 1.54s (± 0.76%) 1.54s (± 0.41%) ~ 1.53s 1.55s p=1.000 n=6
Check Time 2.85s (± 0.48%) 2.86s (± 0.29%) ~ 2.85s 2.87s p=0.170 n=6
Emit Time 0.07s (± 5.69%) 0.07s (±11.12%) ~ 0.07s 0.09s p=1.000 n=6
Total Time 7.75s (± 0.27%) 7.75s (± 0.11%) ~ 7.74s 7.76s p=0.416 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Angular - node (v18.15.0, x64)
  • Compiler-Unions - node (v18.15.0, x64)
  • Monaco - node (v18.15.0, x64)
  • TFS - node (v18.15.0, x64)
  • material-ui - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@gabritto Here are the results of running the user tests comparing main and refs/pull/57467/merge:

Something interesting changed - please have a look.

Details

webpack

tsconfig.types.json

  • [NEW] error TS18048: 'cacheGroup.getName' is possibly 'undefined'.
  • [NEW] error TS2345: Argument of type '(url: string, callback: (arg0: (Error | null) | undefined, arg1: ({ validUntil: number; etag?: string; entry: LockfileEntry; content: Buffer; fresh: boolean;} | { validUntil: number; etag?: string; location: string; fresh: boolean;}) | undefined) => void) => void' is not assignable to parameter of type '(arg0: string, arg1: (arg0?: Error | undefined, arg1?: { validUntil: number; etag?: string | undefined; entry: LockfileEntry; content: Buffer; fresh: boolean; } | { ...; } | undefined) => void) => void'.
  • [NEW] error TS2345: Argument of type '(url: string, callback: (arg0: (Error | null) | undefined, arg1: { entry: LockfileEntry; content: Buffer;} | undefined) => void) => void' is not assignable to parameter of type '(arg0: string, arg1: (arg0?: Error | undefined, arg1?: { entry: LockfileEntry; content: Buffer; } | undefined) => void) => void'.
  • [MISSING] error TS2345: Argument of type '(url: string, callback: (arg0: (Error | null) | undefined, arg1: ({ validUntil: number; etag?: string; entry: LockfileEntry; content: Buffer; fresh: boolean; } | { validUntil: number; etag?: string; location: string; fresh: boolean; }) | undefined) => void) => void' is not assignable to parameter of type '(arg0: string, arg1: (arg0?: Error | undefined, arg1?: { validUntil: number; etag?: string | undefined; entry: LockfileEntry; content: Buffer; fresh: boolean; } | { ...; } | undefined) => void) => void'.
  • [MISSING] error TS2345: Argument of type '(url: string, callback: (arg0: (Error | null) | undefined, arg1: { entry: LockfileEntry; content: Buffer; } | undefined) => void) => void' is not assignable to parameter of type '(arg0: string, arg1: (arg0?: Error | undefined, arg1?: { entry: LockfileEntry; content: Buffer; } | undefined) => void) => void'.

@typescript-bot
Copy link
Collaborator

@gabritto Here are the results of running the top 400 repos comparing main and refs/pull/57467/merge:

Something interesting changed - please have a look.

Details

Eugeny/tabby

11 of 29 projects failed to build with the old tsc and were ignored

tabby-web-demo/tsconfig.json

tabby-web/tsconfig.json

tabby-terminal/tsconfig.json

tabby-telnet/tsconfig.json

tabby-ssh/tsconfig.json

tabby-settings/tsconfig.json

tabby-serial/tsconfig.json

tabby-plugin-manager/tsconfig.json

tabby-local/tsconfig.json

tabby-linkifier/tsconfig.json

tabby-electron/tsconfig.json

tabby-core/tsconfig.typings.json

tabby-core/tsconfig.json

tabby-community-color-schemes/tsconfig.json

gabritto
gabritto requested changes Apr 5, 2024
View reviewed changes
Copy link
Member

@gabritto gabritto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(1) I don't exactly understand how the code change is related to the observed behavior in the repro, if you could provide an explanation that would be very helpful.
(2) There were test changes that I also don't know how they relate to the code change, so would be nice to get an explanation for those too (even if they're bugs). Thanks!

@Andarist
Merge remote-tracking branch 'origin/main' into fix/module-exports-ob…
451824a 
…ject-flags-propagation

# Conflicts:
#	tests/baselines/reference/typedefCrossModule2.types
@Andarist
Copy link
Contributor Author

Andarist commented Apr 7, 2024 •
edited
Loading

  1. IIRC those flags affect isPerformingExcessPropertyChecks. The adjusted code is in getInitializerTypeFromAssignmentDeclaration - this call happens in getWidenedTypeForAssignmentDeclaration and is followed by getWidenedType. To do the widening we need getObjectFlags(type) & ObjectFlags.RequiresWidening and that's what was wrong - the type was never widened so later on (in another module! where the affected type was included as part of something else) isPerformingExcessPropertyChecks was true where it should be false
  2. the in-repo change looks like being related to type inference for object literals. It looks like a correct change to me - it now benefits from this since we are correctly propagating those literal flags. As to the webpack's change from this comment - I'm not sure yet. I just synced with main, could we rerun those tests to get a confirmation that nothing wonky is happening with that report (I'm not sure how likely that is with the current infra)? If it comes back with this error again then I'll happily investigate this (cc @jakebailey )

@gabritto
Copy link
Member

gabritto commented Apr 8, 2024

According to Jake, the extended tests use the latest main, so the not-synced PR shouldn't be a problem, but I can try running again.

@gabritto
Copy link
Member

gabritto commented Apr 8, 2024

@typescript-bot test it

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 8, 2024 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started ✅ Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

@jakebailey
Copy link
Member

My impression at the moment is that the CFA change introduced some non-determinism; that same error went away in that change and is now back again.

@typescript-bot
Copy link
Collaborator

Hey @gabritto, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Collaborator

@gabritto
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Angular - node (v18.15.0, x64)
Memory used 295,779k (± 0.01%) 295,765k (± 0.00%) ~ 295,754k 295,779k p=0.173 n=6
Parse Time 2.66s (± 0.31%) 2.66s (± 0.19%) ~ 2.65s 2.66s p=0.929 n=6
Bind Time 0.83s (± 1.48%) 0.81s (± 0.00%) -0.02s (- 1.82%) 0.81s 0.81s p=0.027 n=6
Check Time 8.20s (± 0.28%) 8.20s (± 0.36%) ~ 8.16s 8.24s p=0.808 n=6
Emit Time 7.04s (± 0.37%) 7.07s (± 0.21%) +0.04s (+ 0.52%) 7.06s 7.10s p=0.035 n=6
Total Time 18.72s (± 0.28%) 18.74s (± 0.11%) ~ 18.70s 18.76s p=0.519 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used 194,048k (± 0.95%) 192,245k (± 0.78%) ~ 191,585k 195,319k p=0.092 n=6
Parse Time 2.03s (± 1.80%) 2.02s (± 1.29%) ~ 1.99s 2.05s p=0.626 n=6
Bind Time 1.06s (± 1.03%) 1.06s (± 0.71%) ~ 1.05s 1.07s p=0.865 n=6
Check Time 13.86s (± 0.26%) 13.83s (± 0.47%) ~ 13.71s 13.90s p=0.519 n=6
Emit Time 3.85s (± 0.54%) 3.85s (± 0.60%) ~ 3.81s 3.87s p=0.805 n=6
Total Time 20.80s (± 0.24%) 20.76s (± 0.27%) ~ 20.67s 20.83s p=0.295 n=6
Monaco - node (v18.15.0, x64)
Memory used 347,687k (± 0.00%) 347,704k (± 0.00%) ~ 347,692k 347,716k p=0.066 n=6
Parse Time 2.99s (± 0.47%) 2.99s (± 0.41%) ~ 2.98s 3.01s p=0.615 n=6
Bind Time 1.07s (± 0.70%) 1.07s (± 0.70%) ~ 1.06s 1.08s p=1.000 n=6
Check Time 8.18s (± 0.17%) 8.20s (± 0.41%) ~ 8.14s 8.22s p=0.257 n=6
Emit Time 4.84s (± 0.38%) 4.85s (± 0.50%) ~ 4.82s 4.89s p=1.000 n=6
Total Time 17.08s (± 0.25%) 17.11s (± 0.18%) ~ 17.06s 17.15s p=0.226 n=6
TFS - node (v18.15.0, x64)
Memory used 302,546k (± 0.01%) 302,550k (± 0.01%) ~ 302,521k 302,583k p=0.936 n=6
Parse Time 2.98s (± 0.62%) 2.95s (± 0.54%) -0.03s (- 1.01%) 2.93s 2.97s p=0.023 n=6
Bind Time 1.44s (± 0.57%) 1.43s (± 0.73%) ~ 1.42s 1.45s p=0.865 n=6
Check Time 9.18s (± 0.52%) 9.17s (± 0.36%) ~ 9.11s 9.21s p=0.746 n=6
Emit Time 5.32s (± 0.54%) 5.30s (± 0.86%) ~ 5.23s 5.35s p=0.687 n=6
Total Time 18.91s (± 0.33%) 18.85s (± 0.31%) ~ 18.79s 18.94s p=0.149 n=6
material-ui - node (v18.15.0, x64)
Memory used 510,604k (± 0.01%) 510,578k (± 0.01%) ~ 510,542k 510,616k p=0.471 n=6
Parse Time 3.93s (± 0.30%) 3.94s (± 0.31%) ~ 3.92s 3.95s p=0.306 n=6
Bind Time 1.44s (± 0.62%) 1.45s (± 0.36%) ~ 1.44s 1.45s p=0.190 n=6
Check Time 25.27s (± 0.28%) 25.18s (± 0.30%) -0.09s (- 0.34%) 25.06s 25.27s p=0.036 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 30.64s (± 0.22%) 30.56s (± 0.26%) ~ 30.44s 30.67s p=0.127 n=6
mui-docs - node (v18.15.0, x64)
Memory used 1,743,874k (± 0.00%) 1,743,906k (± 0.00%) ~ 1,743,873k 1,743,956k p=0.173 n=6
Parse Time 9.62s (± 0.17%) 9.68s (± 0.66%) +0.06s (+ 0.66%) 9.62s 9.79s p=0.023 n=6
Bind Time 3.40s (± 0.82%) 3.41s (± 0.74%) ~ 3.36s 3.43s p=0.684 n=6
Check Time 81.28s (± 0.43%) 81.24s (± 0.43%) ~ 80.85s 81.82s p=0.748 n=6
Emit Time 0.19s (± 2.67%) 0.19s (± 2.67%) ~ 0.19s 0.20s p=1.000 n=6
Total Time 94.49s (± 0.37%) 94.52s (± 0.40%) ~ 94.03s 95.13s p=0.936 n=6
self-build-src - node (v18.15.0, x64)
Memory used 2,299,047k (± 0.03%) 2,299,290k (± 0.04%) ~ 2,298,157k 2,300,212k p=0.689 n=6
Parse Time 6.03s (± 0.63%) 6.03s (± 0.63%) ~ 5.99s 6.09s p=1.000 n=6
Bind Time 2.23s (± 1.39%) 2.22s (± 0.66%) ~ 2.20s 2.24s p=0.745 n=6
Check Time 39.47s (± 0.30%) 39.43s (± 0.39%) ~ 39.17s 39.63s p=0.689 n=6
Emit Time 3.15s (± 3.37%) 3.11s (± 2.77%) ~ 3.01s 3.20s p=0.575 n=6
Total Time 50.88s (± 0.35%) 50.81s (± 0.32%) ~ 50.56s 51.03s p=0.471 n=6
self-build-src-public-api - node (v18.15.0, x64)
Memory used 2,372,557k (± 0.03%) 2,373,103k (± 0.04%) ~ 2,371,928k 2,374,728k p=0.298 n=6
Parse Time 5.18s (± 0.79%) 5.14s (± 1.12%) ~ 5.06s 5.23s p=0.173 n=6
Bind Time 1.69s (± 0.89%) 1.70s (± 0.78%) ~ 1.68s 1.72s p=0.213 n=6
Check Time 33.91s (± 0.28%) 33.95s (± 0.43%) ~ 33.82s 34.15s p=0.873 n=6
Emit Time 2.69s (± 2.05%) 2.66s (± 2.32%) ~ 2.58s 2.74s p=0.378 n=6
Total Time 43.49s (± 0.24%) 43.46s (± 0.26%) ~ 43.29s 43.61s p=0.748 n=6
self-compiler - node (v18.15.0, x64)
Memory used 418,118k (± 0.01%) 418,095k (± 0.01%) ~ 418,061k 418,142k p=0.230 n=6
Parse Time 3.36s (± 0.72%) 3.37s (± 0.80%) ~ 3.33s 3.41s p=0.374 n=6
Bind Time 1.30s (± 1.37%) 1.28s (± 1.62%) ~ 1.25s 1.31s p=0.060 n=6
Check Time 17.83s (± 0.39%) 17.78s (± 0.30%) ~ 17.72s 17.86s p=0.198 n=6
Emit Time 1.39s (± 0.87%) 1.37s (± 1.50%) ~ 1.34s 1.40s p=0.216 n=6
Total Time 23.88s (± 0.35%) 23.80s (± 0.26%) ~ 23.72s 23.88s p=0.127 n=6
vscode - node (v18.15.0, x64)
Memory used 2,903,999k (± 0.00%) 2,904,024k (± 0.00%) ~ 2,903,970k 2,904,080k p=0.230 n=6
Parse Time 15.91s (± 0.36%) 15.95s (± 0.22%) ~ 15.91s 15.99s p=0.145 n=6
Bind Time 4.88s (± 0.44%) 4.91s (± 0.31%) +0.03s (+ 0.65%) 4.88s 4.92s p=0.023 n=6
Check Time 86.13s (± 0.14%) 86.11s (± 0.46%) ~ 85.75s 86.75s p=0.630 n=6
Emit Time 23.77s (± 0.56%) 23.62s (± 0.48%) ~ 23.47s 23.74s p=0.149 n=6
Total Time 130.69s (± 0.16%) 130.59s (± 0.32%) ~ 130.05s 131.12s p=0.471 n=6
webpack - node (v18.15.0, x64)
Memory used 408,691k (± 0.01%) 408,736k (± 0.03%) ~ 408,601k 408,892k p=0.810 n=6
Parse Time 4.78s (± 1.00%) 4.81s (± 0.70%) ~ 4.79s 4.87s p=0.514 n=6
Bind Time 2.03s (± 0.86%) 2.02s (± 0.60%) ~ 2.01s 2.04s p=0.620 n=6
Check Time 20.70s (± 0.35%) 20.66s (± 0.40%) ~ 20.58s 20.80s p=0.520 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 27.50s (± 0.20%) 27.49s (± 0.38%) ~ 27.40s 27.68s p=0.296 n=6
xstate - node (v18.15.0, x64)
Memory used 514,445k (± 0.01%) 514,519k (± 0.01%) ~ 514,487k 514,561k p=0.066 n=6
Parse Time 4.91s (± 0.33%) 4.90s (± 0.71%) ~ 4.84s 4.94s p=0.868 n=6
Bind Time 2.31s (± 0.89%) 2.30s (± 1.72%) ~ 2.26s 2.36s p=0.685 n=6
Check Time 4.24s (± 0.95%) 4.26s (± 1.01%) ~ 4.19s 4.30s p=0.419 n=6
Emit Time 0.11s (± 4.55%) 0.12s (± 4.42%) ~ 0.11s 0.12s p=0.311 n=6
Total Time 11.57s (± 0.37%) 11.58s (± 0.49%) ~ 11.47s 11.62s p=0.520 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Angular - node (v18.15.0, x64)
  • Compiler-Unions - node (v18.15.0, x64)
  • Monaco - node (v18.15.0, x64)
  • TFS - node (v18.15.0, x64)
  • material-ui - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@gabritto Here are the results of running the user tests comparing main and refs/pull/57467/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@gabritto Here are the results of running the top 400 repos comparing main and refs/pull/57467/merge:

Everything looks good!

@Andarist
Copy link
Contributor Author

Andarist commented Apr 8, 2024

Something weird is happening with those tests but I think it's fair to say that it's not related to this PR 😉

@Andarist Andarist requested a review from gabritto April 8, 2024 21:38
@gabritto gabritto merged commit fb1b26c into microsoft:main Apr 16, 2024
25 checks passed
@jakebailey
Copy link
Member

This PR was out of date and broke main.

@gabritto
Copy link
Member

This PR was out of date and broke main.

I'll fix it now

@Andarist Andarist deleted the fix/module-exports-object-flags-propagation branch April 16, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabritto gabritto gabritto approved these changes

@sandersn sandersn Awaiting requested review from sandersn

Assignees

@gabritto gabritto

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Untyped JS module is not assignable to type even though it satisfies it
4 participants
@Andarist @gabritto @typescript-bot @jakebailey