Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Commit

Permalink
New: Add node 9 support and missing env variable on build
Browse files Browse the repository at this point in the history
  • Loading branch information
molant committed Nov 14, 2017
1 parent e560be0 commit 3471441
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 6 deletions.
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,9 @@ You can also download the [protocol.json][protocol].
To build this project you will need [VS2017 Community][vs2017]. Make
sure to select the Windows 10 14393 SDK in the options.

Then run the following commands:
You will also need to install the [windows-build-tools][windows-build-tools].

Once you have the previous dependencies, run the following commands:

```bash

Expand Down Expand Up @@ -133,3 +135,4 @@ any additional questions or comments.
[releases]: https://github.com/Microsoft/EdgeDiagnosticsAdapter/releases
[testsigning]: https://msdn.microsoft.com/en-us/windows/hardware/drivers/install/the-testsigning-boot-configuration-option
[vs2017]: https://www.visualstudio.com/thank-you-downloading-visual-studio/?sku=Community&rel=15
[windows-build-tools]: https://npmjs.com/package/windows-build-tools
4 changes: 3 additions & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
environment:
matrix:
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
nodejs_version: Stable
nodejs_version: 6
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
nodejs_version: LTS
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
nodejs_version: Stable
matrix:
fast_finish: true

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
],
"scripts": {
"copy:static": "cpx \"./src/**/{!(*.ts),.!(ts)}\" out/src",
"build": "npm run clean && npm run lint && npm run build:ts && npm run copy:static && npm run build:native",
"build": "npm run clean && npm run lint && npm run build:ts && npm run copy:static && prebuild.cmd && npm run build:native",
"build:native": "npm config set msvs_version 2015 && gulp buildnative",
"build:ts": "tsc",
"clean": "rimraf out",
Expand Down
11 changes: 8 additions & 3 deletions prebuild.cmd
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
REM If you have installed vs2017 enterprise edition:
REM set VCTargetsPath=C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\VC\VCTargets
set VCTargetsPath=C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\v140
@echo off

IF DEFINED APPVEYOR (
ECHO Building in AppVeyor
) ELSE (
ECHO Setting VCTargetsPath
set VCTargetsPath=\"C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\v140\"
)
set GYP_MSVS_VERSION=2015

0 comments on commit 3471441

Please sign in to comment.