Feature Request: Support Kwallet in addition to libsecret based Linux keyrings

[odensc]

Product and Version [VS/VSCode]: VS Code
OS Version [macOS/Windows]: Kubuntu 18.04 & Arch Linux w/ KDE (both tested)
Live Share Extension Version: 0.2.399

Steps to Reproduce / Scenario:

1. Uninstall/do not install gnome-keyring.
2. Sign in to extension.
3. An error will appear, "The name org.freedesktop.secrets was not provided by any .service files".

gnome-keyring is listed in the prerequisite dependencies, however it would make for a smoother experience on non Gnome-based (such as KDE with KWallet) distros if it was not required to have multiple keyrings installed.

[Chuxel]

@odensc Thanks so much for the feedback! We will take a look and seeing if we can swap it out. We'd apparently gotten lucky with the distros we tested with since even Manjaro Xfce and SuSE KDE had it installed. Appreciate the specifics on the distros you tried.

[Chuxel]

As an update for this issue, it turns out that the issue here is actually likely with KDE's Kwallet implementation. Live Share already uses libsecret, but there are some well-known discussions about this not working with KDE's Kwallet.

See:

• https://mail.kde.org/pipermail/plasma-devel/2016-July/055668.html
• It still requires gnome-keyring even on KDE atom/node-keytar#74
• Remove keyring requirement - replace with cookie/other token (gnome_keyring) lbryio/lbry-desktop#386
• https://bugs.eclipse.org/bugs/show_bug.cgi?id=517110

Live Share would need to do a second implementation for KDE based distros to get this to work seamlessly. Most other desktop environments use gnome-keyring or provide a secrets implementation that works with libsecret.

[edbzn]

Hi, I'm facing this issue too. Any update?

[koutsenko]

Hello, have same issue, any update?

[Mailaender]

I just found

• https://github.com/KDE/ksecrets
• https://community.kde.org/KDE_Utils/ksecretsservice

and actually think this is a KDE upstream issue. Microsoft picked an existing open @freedesktop standard. It just has to be adopted by @KDE.

[24mu13]

That's true.

But exactly the same of remmina could be done here..
Remmina provides a default plugin for secret-service, but still you can use also a plugin for kwallet.

I just found

• https://github.com/KDE/ksecrets
• https://community.kde.org/KDE_Utils/ksecretsservice

and actually think this is a KDE upstream issue. Microsoft picked an existing open @freedesktop standard. It just has to be adopted by @KDE.

[lostintangent]

Closing this as external per the previous comments, and the fact that Live Share is already using libsecret and is only able to officially support a few Linux distros. Please re-open this if you're still running into issues and think this is something we need to investigate. Thanks!