macOS: use 'brew' to upgrade #425
Merged
+227
−175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcheetham
reviewed
Sep 4, 2020
There was a problem hiding this comment.
Do we want to detect which cask we are based on the Git version? I think it might be better and more robust to ask Homebrew which cask flavour is installed (and if none are installed, tell the user "this wasn't installed by Homebrew" (and perhaps a command telling them how to install the brew version).
Thoughts?
derrickstolee
force-pushed
the
upgrade-brew
branch
from
f76170f to
a0c2315
Compare
Preparation for creating 'brew' integration. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
We don't have "Waiting for GVFS lock" or upgrade reminders as part of our Git processes. This carry-over from VFS for Git can be deleted. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee
force-pushed
the
upgrade-brew
branch
from
a0c2315 to
175ae07
Compare
First, move the tracer construction to earlier in the verb. Then, redirect all upgrade logic away from the upgrader scaffolding in favor of simple process calls to 'brew'. Use the Git version to detect if we are in the 'scalar' or 'scalar-azrepos' cask. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee
force-pushed
the
upgrade-brew
branch
from
175ae07 to
d8eda7f
Compare
|
@mjcheetham: I pushed a new version recently that I think answers your "this isn't installed by homebrew" question. Please take a look when you can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are transitioning our entire install and upgrade story to Homebrew on macOS. Update our
scalar upgradeverb to match.Each commit does some cleanup until the last one which does the heavy lifting.
The
scalar upgradecommand will now run two commands:brew updateto get the latest Homebrew formulas and casks.brew upgrade --cask scalar[-azrepos]to actually upgrade. The difference betweenscalarandscalar-azreposis detected from the Git version.