Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement - Activate the extension when gradle files are in sub-folders of the workspace #1570

Merged
merged 2 commits into from
Aug 8, 2024
Merged

enhancement - Activate the extension when gradle files are in sub-folders of the workspace #1570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f24bf03
Refine activationEvents
Jiaaming Aug 8, 2024
0fdec33
rename command
Jiaaming Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...om.microsoft.gradle.bs.importer/src/com/microsoft/gradle/bs/importer/NamedPipeStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ private String generateRandomPipeName() {

private void sendImporterPipeName(String pipeName) {
JavaLanguageServerPlugin.getInstance().getClientConnection()
.sendNotification("gradle.onWillImporterConnect", pipeName);
.sendNotification("_gradle.onWillImporterConnect", pipeName);
}

private void attemptConnection(File pipeFile) throws IOException {
Expand Down
7 changes: 6 additions & 1 deletion extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,14 @@
"workspaceContains:**/gradlew",
"workspaceContains:**/gradlew.bat",
"workspaceContains:build.gradle",
"workspaceContains:*/build.gradle",
"workspaceContains:settings.gradle",
"workspaceContains:*/settings.gradle",
"workspaceContains:build.gradle.kts",
"workspaceContains:settings.gradle.kts"
"workspaceContains:*/build.gradle.kts",
"workspaceContains:settings.gradle.kts",
"workspaceContains:*/settings.gradle.kts",
"onCommand:_gradle.onWillImporterConnect"
],
"main": "./dist/index.js",
"contributes": {
Expand Down
2 changes: 1 addition & 1 deletion extension/src/bs/JdtlsImporterConnector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import * as vscode from "vscode";
import * as path from "path";
import { sendInfo } from "vscode-extension-telemetry-wrapper";

export const ON_WILL_IMPORTER_CONNECT = "gradle.onWillImporterConnect";
export const ON_WILL_IMPORTER_CONNECT = "_gradle.onWillImporterConnect";

/**
* Receive the pipe name from Java jdt.ls importer, generate named pipe file and
Expand Down
Loading