Gradle project view keeps project hierarchy #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements microsoft#945 by parsing the project path which is found in the 'definition.script' property. The project path, which is unique for every subproject, is then used as key in the 'projectTreeItemMap'.
|
@microsoft-github-policy-service agree |
|
Thank you @jjohannes. I'm just back from vacation and will review this contribution ASAP. |
jdneo
approved these changes
Oct 8, 2024
|
Thank you for the quick response and integrating this @jdneo. |
|
I found an issue about this change that some of the modules are in the wrong place:
For example, here: the Clone and open the project https://github.com/microsoft/build-server-for-gradle can reproduce the error |
jjohannes
added a commit
to jjohannes/vscode-gradle
that referenced
this pull request
Oct 14, 2024
In microsoft#1612, the keys of this map were changed to the Gradle project path. This path is unique for each project within one Gradle build, but not if there are multiple Gradle builds loaded in one workspace by using: 'gradle.nestedProjects': true This change combined the old and new behavior by creating the Map key from two parts: (1) The root project folder which uniquely identifies the build (accessible via definition.projectFolder) (2) The Gradle project path that uniquely identifies a project inside the build
jjohannes
added a commit
to jjohannes/vscode-gradle
that referenced
this pull request
Oct 14, 2024
In microsoft#1612, the keys of this map were changed to the Gradle project path. This path is unique for each project within one Gradle build, but not if there are multiple Gradle builds loaded in one workspace by using: 'gradle.nestedProjects': true This change combined the old and new behavior by creating the Map key from two parts: (1) The root project folder which uniquely identifies the build (accessible via definition.projectFolder) (2) The Gradle project path that uniquely identifies a project inside the build Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
jdneo
pushed a commit
that referenced
this pull request
Oct 16, 2024
In #1612, the keys of this map were changed to the Gradle project path. This path is unique for each project within one Gradle build, but not if there are multiple Gradle builds loaded in one workspace by using: 'gradle.nestedProjects': true This change combined the old and new behavior by creating the Map key from two parts: (1) The root project folder which uniquely identifies the build (accessible via definition.projectFolder) (2) The Gradle project path that uniquely identifies a project inside the build Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #945 by parsing the project path which is found in the
definition.scriptproperty. The project path, which is unique for every subproject, is then used as key in theprojectTreeItemMap.