Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for prerelease switch #8657

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Ask for prerelease switch #8657

merged 2 commits into from
Jan 14, 2022

Conversation

rchiodo
Copy link
Contributor

@rchiodo rchiodo commented Jan 7, 2022

This is a temporary fix to address comments made here:

microsoft/vscode#15756 (comment)

If an insider's user is not on the prerelease bits, we'll ask them to switch.

Message looks like so:

image

@rchiodo rchiodo requested a review from a team as a code owner January 7, 2022 21:31
@rchiodo
Copy link
Contributor Author

rchiodo commented Jan 7, 2022

This requires this to be fixed first:
microsoft/vscode#139528.

I thought that was already working. Turns out it isn't finished yet.

@rchiodo rchiodo closed this Jan 10, 2022
@rchiodo rchiodo reopened this Jan 14, 2022
@rchiodo
Copy link
Contributor Author

rchiodo commented Jan 14, 2022

microsoft/vscode#139528 was fixed yesterday. Reopening this.

@codecov-commenter
Copy link

Codecov Report

Merging #8657 (dd2be8a) into main (622aab5) will increase coverage by 0%.
The diff coverage is 78%.

@@           Coverage Diff           @@
##            main   #8657     +/-   ##
=======================================
  Coverage     71%     72%             
=======================================
  Files        382     385      +3     
  Lines      24523   25794   +1271     
  Branches    3767    4198    +431     
=======================================
+ Hits       17542   18609   +1067     
- Misses      5457    5606    +149     
- Partials    1524    1579     +55     
Impacted Files Coverage Δ
src/client/datascience/prereleaseChecker.ts 73% <73%> (ø)
src/client/common/utils/localize.ts 96% <100%> (+<1%) ⬆️
src/client/datascience/serviceRegistry.ts 98% <100%> (+<1%) ⬆️
src/client/datascience/utils.ts 44% <0%> (-3%) ⬇️
...ence/notebook/intellisense/intellisenseProvider.ts 79% <0%> (-1%) ⬇️
src/client/debugger/jupyter/kernelDebugAdapter.ts 77% <0%> (-1%) ⬇️
src/client/common/types.ts 100% <0%> (ø)
src/client/datascience/constants.ts 100% <0%> (ø)
...ent/datascience/jupyter/pythonVariableRequester.ts 76% <0%> (ø)
src/client/datascience/delayedFutureExecute.ts 58% <0%> (ø)
... and 19 more

@rchiodo rchiodo merged commit da0b236 into main Jan 14, 2022
@rchiodo rchiodo deleted the rchiodo/ask_to_switch_prerelease branch January 14, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants