Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve notebook rendering jitter #126432

Closed
roblourens opened this issue Jun 16, 2021 · 6 comments
Closed

Improve notebook rendering jitter #126432

roblourens opened this issue Jun 16, 2021 · 6 comments
Assignees
@roblourens
Labels
feature-request Request for new features or functionality notebook-perf verification-needed Verification of issue is requested verified Verification succeeded
Milestone
January 2022

Comments

@roblourens
Copy link
Member

Things to look into

  • Can the viewmodel on the webview side be smarter and anticipate layout changes?
  • How long do layouts on both sides take?
  • Are sending messages slow?
@roblourens roblourens added feature-request Request for new features or functionality notebook labels Jun 16, 2021
@roblourens roblourens added this to the June 2021 milestone Jun 16, 2021
@roblourens roblourens self-assigned this Jun 16, 2021
roblourens added a commit that referenced this issue Jun 18, 2021
@roblourens
Fix "ack height" running with an out of date cell height
22bec9b 
Towards #126432
@kieferrm kieferrm mentioned this issue Jun 22, 2021
Closed
72 tasks
@roblourens
Copy link
Member Author

roblourens commented Jul 1, 2021 •
edited
Loading

I have a stash with a bunch of changes that shift some things around but do not really make the user perception better. Fixing the layout too early is basically just as bad as fixing it too late. Let's talk about this @rebornix and you can help me figure out whether any of this can go anywhere.

@roblourens roblourens modified the milestones: June 2021, July 2021 Jul 1, 2021
@rebornix
Copy link
Member

rebornix commented Jul 1, 2021 •
edited
Loading

@roblourens yup, let's meet some time to discuss them. Maybe with little bit tweaks your changes can improve the layout by a lot.

This was referenced Jul 11, 2021
Closed
Closed
@roblourens roblourens modified the milestones: July 2021, August 2021 Jul 29, 2021
@kieferrm kieferrm mentioned this issue Aug 8, 2021
Closed
91 tasks
@roblourens roblourens mentioned this issue Aug 12, 2021
Closed
@egamma egamma mentioned this issue Sep 6, 2021
Closed
99 tasks
@rebornix rebornix removed the notebook label Oct 21, 2021
@kieferrm kieferrm mentioned this issue Nov 7, 2021
Closed
82 tasks
@rebornix
Copy link
Member

rebornix commented Dec 15, 2021 •
edited
Loading

Fixed via d99e352...b5c1882 .

@kieferrm kieferrm mentioned this issue Dec 21, 2021
Closed
91 tasks
@hediet hediet added the verification-needed Verification of issue is requested label Jan 25, 2022
@jrieken jrieken added the verification-steps-needed Steps to verify are needed for verification label Jan 26, 2022
@rzhao271
Copy link
Contributor

What are some steps to verify this issue?

@alexr00
Copy link
Member

alexr00 commented Jan 27, 2022

If setting stable and insiders side-by-side and scrolling through the ".vscode\notebooks\my-endgame.github-issues" file in each and deciding that insiders looks better counts as verifying then I've verified it 😁

@roblourens roblourens added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Jan 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
feature-request Request for new features or functionality notebook-perf verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
January 2022
Development

No branches or pull requests
8 participants
@roblourens @rebornix @jrieken @hediet @rzhao271 @tanhakabir @alexr00 and others