Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Filter with spaces does not work when docked in bottom panel #130543

Closed
smcenlly opened this issue Aug 11, 2021 · 1 comment · Fixed by #130731
Closed

Test Filter with spaces does not work when docked in bottom panel #130543

smcenlly opened this issue Aug 11, 2021 · 1 comment · Fixed by #130731
Assignees
@connor4312
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded
Milestone
August 2021

Comments

@smcenlly
Copy link
Contributor

Version: 1.60.0-insider (Universal)
Commit: 49af1cb
Date: 2021-08-06T06:42:17.124Z
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Darwin arm64 20.5.0

Steps to Reproduce:

  1. Use an extension that uses the new VS Code test API
  2. Dock the Test side bar to the bottom panel
  3. Try and type space character (it does not appear in filter box); it does work when Test position is reset.

See video below

filter_not_working.mp4
@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug testing Built-in testing support labels Aug 11, 2021
@connor4312 connor4312 added this to the August 2021 milestone Aug 13, 2021
@connor4312 connor4312 mentioned this issue Aug 13, 2021
Merged
@stuartleeks
Copy link

Verified working in

Version: 1.60.0-insider (user setup)
Commit: b71e20ceba833fcb2efada1a4765929ff96ccbb1
Date: 2021-08-26T05:13:37.746Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19043

@stuartleeks stuartleeks added the verified Verification succeeded label Aug 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded
Projects
None yet
Milestone
August 2021
Development

Successfully merging a pull request may close this issue.

testing: support for test tags in search microsoft/vscode
4 participants
@stuartleeks @smcenlly @connor4312 and others