testing: support for test tags in search #130731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also involves creating a suggest enabled input with history, which I modelled off the previous plain text input with history.
Closed
sandy081
reviewed
Aug 17, 2021
| @@ -13,7 +13,8 @@ import { ContextKeyExpr, IContextKey, IContextKeyService, IContextKeyServiceTarg | |||
| import { KeybindingsRegistry, KeybindingWeight } from 'vs/platform/keybinding/common/keybindingsRegistry'; | |||
|
|
|||
| export const HistoryNavigationWidgetContext = 'historyNavigationWidget'; | |||
| export const HistoryNavigationEnablementContext = 'historyNavigationEnabled'; | |||
| const HistoryNavigationForwardsEnablementContext = 'historyNavigationForwardsEnabled'; | |||
There was a problem hiding this comment.
Any reason for breaking the original context into two?
There was a problem hiding this comment.
We want to allow navigating the history backwards when the cursor is at the first position, and forwards when it's at the last. This matches the behavior of SCM's implementation of history (which I looked into reusing but is very coupled to SCM)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also involves creating a suggest enabled input with history, which
I modelled off the previous plain text input with history. (cc Sandeep)
Fixes #126938
Fixes #130543 (by virtue of the filter always being in the view and not the menu bar any more)