-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf: review slow running early workbench contributions #159675
Comments
aeschli
added a commit
that referenced
this issue
Sep 1, 2022
aeschli
added a commit
that referenced
this issue
Sep 1, 2022
aeschli
added a commit
that referenced
this issue
Sep 1, 2022
Thanks! |
Due to #159875, I'd like to split |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Refs: #156864
I instrumented slow running code that executes via
registerWorkbenchContribution
at an early stage before editors restore. In devtools you will see a warning in case the contribution needs more than5ms
being instantiated:The time we spend here is time we take away from the user before the editor contents appear, thus we block the critical startup path.
I did some experiments from a custom build that includes this change on platforms and found some contributions that constantly appeared with above
5ms
construction times.Task
LifecyclePhase.Restored
or evenLifecyclePhase.Eventually
List
LocalTerminalBackendContribution
@TyriarExtensionsContribution
@sandy081PreferencesActionsContribution
@rzhao271UserDataSyncWorkbenchContribution
@sandy081ExtensionsViewletViewsContribution
@sandy081InteractiveDocumentContribution
@rebornixRemoteEmptyWorkbenchContribution
@aeschliThe text was updated successfully, but these errors were encountered: