-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] --list-extensions --show-versions
should annotate the packages that are in pre-release
#196155
Comments
I'd be interested in working on this. What would be the desired indication for a package to be pre-release? |
Thanks for your interest in implementing this feature, for me, as long as its format is parsable and can be used to distinguish between different extension types, it is acceptable From the VS Code side, I think the format should be standardized and support all the extension types, it seems that VS Code supports the following extension types:
Though I am not a VS Code user so the above summary could be wrong |
I would stick just showing if the extension is a pre-release or not and not the type of the extension. |
I am not convinced about the second request yet. Lets focus on the first one which is reasonable. |
Willing to elaborate on it a bit? |
I do not see a necessity to inform if the extension is coming from the Marketplace or as a VSIX. |
Frankly, I asked for a reason in my last comment, you didn't answer it, you simply say you don't like it. An open source community should not work like this. It is total fine that we disagree on something, but we need at least a reason. Anyway, you are the maintainer, you decide. |
I gave my reason that I do not see a necessity of this. In order to accept new features and contributions we should need a proper reason, requirement and if it is worth a feature to accept it. Since I do not see such I am not in favour. Hope this explains. |
Ok Would this suffice? Another issue that code --install-extension cannot handle, just like the one described in this issue |
Seeing this discussion becoming a standoff, I think it would be useful to clearly add a bit of context here. I developed some time ago on the system-wide updater Topgrade, the feature to update vscode extensions from the marketplace.
This works very well for most of the extensions, but few corner cases are not handled by this process, and were reported by users, in order:
To fix the first one, the maintainer of Topgrade, SteveLauC, have created this issue, and when the second one was reported, it was also stated within this comment. To be complete, the third one has been stated much more recently so it was not stated in this thread. This means that, for the CLI to correctly allow extensions management, there is a necessity to properly differentiate the extensions origin/types/status (whatever we want to call that) using the --list-extensions command. However, if you really think this is impractical, other ways would be possible of course:
Hope this explanation clarify the needs behind that feature. |
Thanks for the explanation and it gives me the context. For your usecase I recommend to a update-extensions command. I have reopened the issue and I would accept PR for that (as you can see IMO giving Therefore, I would stick this issue to expose only pre-release information. If needed, please file a separate issue for source information with valid usecase. |
We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider. If you wonder what we are up to, please see our roadmap and issue reporting guidelines. Thanks for your understanding, and happy coding! |
Context
In Topgrade, we are using the following commands to update VS Code extensions:
This won't work if you have an extension that is in pre-release:
code
has an option--pre-release
that could be used with--install-extensions
to install the pre-release version of an extension, but before using it, we need to know which extensions are in pre-release, then we tried the--show-versions
option, unfortunately, it won't tell you that:Requested Feature
should tell us what extensions are in pre-release
Topgrade Issue
pre-release version of vscode extension update error
The text was updated successfully, but these errors were encountered: