Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Allow test runs to run tests outside of the original scope #213182

Closed
pavelfeldman opened this issue May 21, 2024 · 1 comment · Fixed by #213945
Closed

[Testing] Allow test runs to run tests outside of the original scope #213182

pavelfeldman opened this issue May 21, 2024 · 1 comment · Fixed by #213945
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded
Milestone

Comments

@pavelfeldman
Copy link
Member

Does this issue occur when all extensions are disabled?: No

  • VS Code Version: 1.90
  • OS Version: all

Context
We have a notion of project/test dependencies, so when I run a test TEST, I might need to run another SETUP test first. This however is not supported out of the box - if my SETUP test is outside of the scope of TEST, no rendering on its progress happens in the sidebar.

Workaround
The way I work around it is I create a new test run with a root of the workspace in it. Then it reports progress on all the tests.

Side-effect
It has a following side effect though: one "Test run" history entry is created for the original handle invocation and another one is created for my createTestRun

Request
I'd say there are two requests here:

  1. Only create test log entry when createTestRun is invoked, do not create one automatically.
  2. Allow for tests outside of the original scope to show their progress

//cc @connor4312

@microsoft microsoft deleted a comment from vscodenpa May 21, 2024
@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug testing Built-in testing support labels May 30, 2024
@connor4312
Copy link
Member

Yea, we can probably remove the restriction. I put it there when I first made the API to be a guardrail against invalid logic from extensions, but if there's a use case for it I'm fine removing it.

@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label May 31, 2024
@vscodenpa vscodenpa added this to the June 2024 milestone May 31, 2024
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 5, 2024
@eleanorjboyd eleanorjboyd added the verified Verification succeeded label Jun 26, 2024
@microsoft microsoft locked and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants