Editor Jumps When Code Lenses Are Inserted

[hediet]

I think the editor used to preserve the vertical position of the line where the the cursor is in.
It jumps now:

Repro steps:

• Enable Code Lenses for TypeScript
• Navigate to a symbol in a file that has not been opened yet
• Notice that the editor reveals the symbol correctly, but without code lenses yet
• Notice that the editor jumps once code lenses appear

Verification steps:

• Observe that the line the cursor is in does not jump anymore.

If I don't misremember, there was a change made here recently?

[jrieken]

If I don't misremember, there was a change made here recently?

No changes for code lens since long. Doesn't reproduce for me. Can yo consistently repro? Can you try without custom settings?

Screen.Recording.2024-06-21.at.18.14.03.mov

[alexdima]

@hediet The current logic is to keep the first line in the viewport stable. A good improvement might be to keep the line where the cursor is stable (if it's in the viewport), but that is not what we have implemented. PR welcome.

[hediet]

Oh, somehow I didn't realizing the jumping then.

No changes for code lens since long. Doesn't reproduce for me. Can yo consistently repro? Can you try without custom settings?

Did you open this file before in the VS Code session?
In the first frame of your screenrecording where editorBrowser.ts shows, the code lens feature already reserved some (empty) space to prevent layout shifts (which I don't think the feature knows the first time the text model is opened):

[jrieken]

the code lens feature already reserved some (empty) space to prevent layout shifts (which I don't think the feature knows the first time the text model is opened):

Between reloads the slots are persisted and optimistically shown for a couple of seconds so that the actual extension/provider can compute theirs (which is usually the same)

[hediet]

I think there is something fishy going on with persisting the code lens cache (#221005).

[vs-code-engineering]

Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the insiders-released label directly, or comment \closedWith someShaThatWillbeReleasedWhenThisIsRelesed.

[vs-code-engineering]

		Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting `\closedWith someCommitSha`, or directly add the `insiders-released` label if you know this has already been releaased

[hediet]

Closing in favor of #224822 (which proposes one possible solution to this).

To be honest though, I think #221005 is what caused my feeling of this happening much more often.