Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGL renderer doesn't work with tasks #85048

Closed
Tyriar opened this issue Nov 18, 2019 · 0 comments
Closed

WebGL renderer doesn't work with tasks #85048

Tyriar opened this issue Nov 18, 2019 · 0 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
November 2019

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 18, 2019

Repro:

  1. Set rendererType to experimentalWebgl
  2. Clone xterm.js
  3. yarn
  4. ctrl/cmd+shift+b

Expected: 2 tasks run in split terminals
Actual: The terminals are blank
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) terminal General terminal issues that don't fall under another label labels Nov 18, 2019
@Tyriar Tyriar added this to the November 2019 milestone Nov 18, 2019
@Tyriar Tyriar self-assigned this Nov 18, 2019
@Tyriar Tyriar mentioned this issue Nov 19, 2019
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Nov 23, 2019
@Tyriar
Prevent atlas missing exception when opened before attach
0bd0f3a 
See microsoft/vscode#85048
@Tyriar Tyriar mentioned this issue Nov 23, 2019
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Nov 24, 2019
@Tyriar
Don't throw when rendering before atlas is set
53fb1ba 
This fixes a problem when loading the webgl addon before the terminal
is attached.

See microsoft/vscode#85048
@Tyriar Tyriar mentioned this issue Nov 24, 2019
Merged
@Tyriar Tyriar closed this as completed in 3e3cb30 Nov 24, 2019
@Tyriar Tyriar added the verified Verification succeeded label Dec 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 8, 2020
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
xterm-addon-webgl@0.4.0-beta.11
5b7c389 
Fixes microsoft#85048
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
November 2019
Development

No branches or pull requests
1 participant
@Tyriar