Enlarge small markdown text size - trivial change #134550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
reviewed
Oct 7, 2021
| margin: 0; | ||
| margin-bottom: 10px; | ||
| margin-bottom: 2px; |
There was a problem hiding this comment.
Should the margins be rem size too?
There was a problem hiding this comment.
Maybe? Though I wasn't sure that the prior px definitions weren't done on purpose by @mjbvz for some reason I'm not aware of. Since I don't consider myself an expert in these matters.
There was a problem hiding this comment.
Better to use em here IMO. That way the size of the header is based on the font size in the current context instead of the root document
mjbvz
approved these changes
Oct 7, 2021
rchiodo
approved these changes
Oct 8, 2021
|
Thanks! Let's see what this looks like in insiders |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially and trivially addresses #126294. It's a simple modification of default markdown font sizes for h1, h2, h3, and p, as there have been many complaints about the small size of regular text (p) elements.
On Windows, these changes result in very similar sizing for affected elements as is displayed in Jupyter. Not sure how these changes perform on Mac/Linux yet.