Merge internal options to timeline options #147304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #145983
Merges
InteralOptionsintoTimelineOptions. The timeline options structure was entirely optional before so this seems like a safe change.The main downside to this is now the timeline API technically has access to the
cacheResultandresetCacheflag despite it not being exposed in the.d.tsinterface. They would of course have to probe the source code for this and since it's undocumented we make no guarantees of future compatibility.I didn't feel comfortable removing
cacheResultdespite it always being passed as true as I don't know enough about how the caching works currently./cc @bpasero