Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working copy - allow to custom save method on model (#172345) #185963

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Jun 23, 2023

Part of #172345

This allows a stored file working copy model to implement the save method. Notebooks could opt-in to use this method, if:

  • the notebook is stored remotely (to improve perf)
  • maybe behind a setting in the beginning or only enabled in insiders

The model that implements save needs to:

  • respect cancellation token
  • respect the passed in write options (specifically should support etag validation)
  • most importantly make sure that the data that gets saved is in-sync with the notebook editor on the renderer

@bpasero bpasero merged commit 675314d into main Jun 23, 2023
@bpasero bpasero deleted the ben/devoted-ferret branch June 23, 2023 17:43
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants