Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: use declare enum instead of declare const enum for typescrip… #212909

Closed
wants to merge 1 commit into from
Closed

feature: use declare enum instead of declare const enum for typescrip… #212909

wants to merge 1 commit into from

Conversation

SimonSiefke
Copy link
Contributor

@SimonSiefke SimonSiefke commented May 16, 2024 •
edited
Loading

…t isolated modules

Part of #212835

For testing, I enabled isolatedModules in src/tsconfig.json and checked that no error is shown anymore in amd.ts and perfviewEditor.ts.

@RIZKYARDIANSYAH25 RIZKYARDIANSYAH25 mentioned this pull request May 16, 2024
Closed
@SimonSiefke SimonSiefke mentioned this pull request May 16, 2024
Closed
@SimonSiefke
Copy link
Contributor Author

Moved to #212913

@SimonSiefke SimonSiefke deleted the feature/cannot-access-ambient-const-enums branch May 16, 2024 16:54
@microsoft microsoft locked and limited conversation to collaborators Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonSiefke @mjbvz