Add url handling for settings and adopt in release notes #219702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
reviewed
Jul 2, 2024
src/vs/workbench/services/preferences/common/preferencesUrlHandler.ts
Outdated
Show resolved
Hide resolved
|
CI tests also claim that there is a leaking disposable |
alexr00
commented
Jul 3, 2024
src/vs/workbench/services/preferences/browser/preferencesService.ts
Outdated
Show resolved
Hide resolved
|
Unit tests fail |
rzhao271
approved these changes
Jul 8, 2024
aaronchucarroll
pushed a commit
to aaronchucarroll/vscode
that referenced
this pull request
Jul 10, 2024
…19702) * Add url handling for settings and adopt in release notes Fixes microsoft#212079 * Update regex to use product service, fix test * Incorporate feedback * Check value of setting before passing to settings editor * Fix test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #212079