mcp: support workspace folder-level servers #244066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationalizes some of our workspace vs workspace folder handling. Both
should now work, and this adds proper support for workspace folder-level
servers (detectable where previously resolving `${workspaceFolder}`
would not work, mcp servers would only be found in the 1st folder, etc).
MCP servers defined in a workspace folder are `root`ed to that single
folder instead of seeing the entire workspace. #244064 for more future
discussion there.
Fixes #244029
roblourens
previously approved these changes
Mar 20, 2025
TylerLeonhardt
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationalizes some of our workspace vs workspace folder handling. Both
should now work, and this adds proper support for workspace folder-level
servers (detectable where previously resolving
${workspaceFolder}would not work, mcp servers would only be found in the 1st folder, etc).
MCP servers defined in a workspace folder are
rooted to that singlefolder instead of seeing the entire workspace. #244064 for more future
discussion there.
Fixes #244029