Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-rendering Markdown preview when updated extra configurations provided by extension #71442

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

vitaliymaz
Copy link

No description provided.

@vitaliymaz vitaliymaz force-pushed the fix-markdonw-re-render branch 2 times, most recently from da020e7 to 4e46b99 Compare March 29, 2019 10:52
@vitaliymaz
Copy link
Author

fixes #70936

@mjbvz
Copy link
Collaborator

mjbvz commented Mar 31, 2019

Thanks for looking into this. I feel this is an overly complicated solution however that is too tried to the use case from #70936.

How about just making markdown.preview.refresh invalidate the cached document and then refresh the markdown content? That way, the extensions themselves decide when to re-render.

@vitaliymaz vitaliymaz force-pushed the fix-markdonw-re-render branch from 4e46b99 to e40d72b Compare April 1, 2019 08:53
@vitaliymaz
Copy link
Author

@mjbvz, I've updated my fix. Now refresh command just cleans cache before an update.

@mjbvz mjbvz added this to the April 2019 milestone Apr 2, 2019
@mjbvz mjbvz merged commit 37c9a75 into microsoft:master Apr 2, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 2, 2019

Thanks! This will be in the first 1.34 insiders builds and is scheduled to go out with the April release

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants