Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "accept local" and "accept remote" buttons to setting conflict notification #90190

Merged
merged 3 commits into from
Feb 11, 2020

Conversation

roblourens
Copy link
Member

Fixes #84431

Pretty straightforward but I wanted to run it by you @sandy081

@roblourens roblourens requested a review from sandy081 February 7, 2020 01:05
@roblourens roblourens self-assigned this Feb 7, 2020
@sandy081
Copy link
Member

sandy081 commented Feb 7, 2020

@roblourens Does this shall also consider keybindings? Keybindings also go through same code path.

@roblourens roblourens force-pushed the roblou/resolveConflicts branch from 155cc2e to da0de90 Compare February 11, 2020 01:47
@roblourens
Copy link
Member Author

Now it does!

Copy link
Member

@sandy081 sandy081 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will do some minor tweaks.

Thanks

@sandy081 sandy081 merged commit 45bbe40 into master Feb 11, 2020
@sandy081 sandy081 deleted the roblou/resolveConflicts branch February 11, 2020 08:45
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings sync for settings GUI
2 participants