fix: resolve javadoc and source locations #2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sources jar from pipeline artifacts are confirmed to have moved from the generated folder. javadoc artifacts are now non empty |
baywet
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2078
fixes #1893
This PR includes the following changes.
/generatedfolder up one folder so that the generated sources are in the correct package structureConsiderations.
As much as updating the generation pipeline to place the generated files in the correct package structure is a good idea, we have a number of hand writter files in the root path such as #2298 that would be overwritten or replaced. The alternative would involve keeping a record of handwritten files and moving them just in time but that would increase the maintenance burden.