Fix regression in content_type for text part after converted to multipart #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there @jeremyevans good work on this, sorry for the radio silence. Can you please rebase this against Master and against 2-8-stable and I'll get these released in the next updates. |
…part This was broken by 404ecdd. It removed the setting of the default :content_type entry for the text part, before copying the content fields to the text part. This puts back the setting of the default :content_type entry for the text part. In 2.7.1: ```ruby m = Mail.new m.body 'c' m.add_file :filename=>'a.txt', :content=>'b' m.parts.first.content_type =~ /text\/plain/ # => 0 ``` Before this commit: ```ruby m = Mail.new m.body 'c' m.add_file :filename=>'a.txt', :content=>'b' m.parts.first.content_type =~ /text\/plain/ # => nil m.encoded m.parts.first.content_type =~ /text\/plain/ # => 0 ``` After this commit: ```ruby m = Mail.new m.body 'c' m.add_file :filename=>'a.txt', :content=>'b' m.parts.first.content_type =~ /text\/plain/ # => 0 ```
jeremyevans
force-pushed
the
content-type-regression-fix
branch
from
992e8fe to
89f55e5
Compare
|
@mikel OK, this is rebased against master. Would you like me to send a separate pull request that is against 2-8-stable? |
radar
approved these changes
Jan 21, 2025
|
Thanks @jeremyevans. I think we will get this into the 2.9.x release I plan on cutting in the next few weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken by 404ecdd. It removed
the setting of the default :content_type entry for the text part, before
copying the content fields to the text part. This puts back the setting
of the default :content_type entry for the text part.
In 2.7.1:
Before this commit:
After this commit:
Regression found by Roda's mailer plugin tests.